[DevTools] Fixed inline scope variables for object property

[DevTools] Fixed inline scope variables for object property

BUG=593937
R=lushnikov@chromium.org

Committed: https://crrev.com/b5a068cae369175fcf0cc9bd1a214d3cbbe8cefd
Cr-Commit-Position: refs/heads/master@{#423049}

[kozy, 2016-10-04 17:21:22]

Description was changed from

==========
[DevTools] Fixed inline scope variables for object property

BUG=593937
R=dgozman@chromium.org
==========

to

==========
[DevTools] Fixed inline scope variables for object property

BUG=593937
R=lushnikov@chromium.org
==========

[kozy, 2016-10-04 17:21:22]

kozyatinskiy@chromium.org changed reviewers:
+ lushnikov@chromium.org
- dgozman@chromium.org

[kozy, 2016-10-04 17:21:32]

Andrey, please take a look!

[lushnikov, 2016-10-04 23:31:31]

lgtm

https://codereview.chromium.org/2388903004/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
(right):

https://codereview.chromium.org/2388903004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:715:
var skipNextToken = false;
let's name this skipObjectProperty so that reader would have at least some idea
why
we do this

[kozy, 2016-10-05 00:10:22]

All done, thanks!

https://codereview.chromium.org/2388903004/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
(right):

https://codereview.chromium.org/2388903004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:715:
var skipNextToken = false;
On 2016/10/04 23:31:31, lushnikov wrote:
> let's name this skipObjectProperty so that reader would have at least some
idea
> why
> we do this

Done.

[kozy, 2016-10-05 00:10:26]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-10-05 00:10:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2388903004/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-10-05 00:10:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 02:15:50]

Description was changed from

==========
[DevTools] Fixed inline scope variables for object property

BUG=593937
R=lushnikov@chromium.org
==========

to

==========
[DevTools] Fixed inline scope variables for object property

BUG=593937
R=lushnikov@chromium.org
==========

[commit-bot: I haz the power, 2016-10-05 02:15:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 02:18:24]

Description was changed from

==========
[DevTools] Fixed inline scope variables for object property

BUG=593937
R=lushnikov@chromium.org
==========

to

==========
[DevTools] Fixed inline scope variables for object property

BUG=593937
R=lushnikov@chromium.org

Committed: https://crrev.com/b5a068cae369175fcf0cc9bd1a214d3cbbe8cefd
Cr-Commit-Position: refs/heads/master@{#423049}
==========

[commit-bot: I haz the power, 2016-10-05 02:18:25]

Patchset 2 (id:??) landed as
https://crrev.com/b5a068cae369175fcf0cc9bd1a214d3cbbe8cefd
Cr-Commit-Position: refs/heads/master@{#423049}