Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 23889030: Speed up GM ~50% by NOT running most renderModes by default (Closed)

Created:
7 years, 3 months ago by epoger
Modified:
7 years, 3 months ago
Reviewers:
borenet, bsalomon
CC:
skia-review_googlegroups.com, robertphillips, reed1
Visibility:
Public.

Description

Speed up GM ~50% by NOT running most renderModes by default BUG=skia:1566 R=borenet@google.com, bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=11265

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -55 lines) Patch
M gm/gmmain.cpp View 2 chunks +6 lines, -6 lines 2 comments Download
M gm/tests/outputs/add-config-pdf/output-expected/stdout View 1 chunk +3 lines, -3 lines 2 comments Download
M gm/tests/outputs/checksum-based-filenames/output-expected/stdout View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/tests/outputs/compared-against-different-pixels-images/output-expected/stdout View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/tests/outputs/compared-against-different-pixels-json/output-expected/stdout View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/tests/outputs/compared-against-empty-dir/output-expected/stdout View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes-images/output-expected/stdout View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes-json/output-expected/stdout View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels-images/output-expected/stdout View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels-json/output-expected/stdout View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/tests/outputs/ignore-expectations-mismatch/output-expected/stdout View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/tests/outputs/ignoring-some-failures/output-expected/stdout View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/tests/outputs/intentionally-skipped-tests/output-expected/stdout View 1 chunk +4 lines, -4 lines 0 comments Download
M gm/tests/outputs/no-hierarchy/output-expected/stdout View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/tests/outputs/no-readpath/output-expected/stdout View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/tests/outputs/nonverbose/output-expected/stdout View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/pipe-playback-failure/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/pipe-playback-failure/output-expected/stdout View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/tests/run.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
epoger
https://codereview.chromium.org/23889030/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.chromium.org/23889030/diff/1/gm/gmmain.cpp#newcode1370 gm/gmmain.cpp:1370: DEFINE_bool(deferred, false, "Exercise the deferred rendering test pass."); I ...
7 years, 3 months ago (2013-09-13 19:00:37 UTC) #1
epoger
Er, I guess this is a ~100% speedup. Anyway, it takes half as long as ...
7 years, 3 months ago (2013-09-13 19:01:40 UTC) #2
borenet
Code change LGTM. CC Rob and Mike to make sure we really don't care about ...
7 years, 3 months ago (2013-09-13 19:04:54 UTC) #3
epoger
On 2013/09/13 19:04:54, borenet wrote: > Do we care about 565? FYI, 565 doesn't seem ...
7 years, 3 months ago (2013-09-13 19:14:58 UTC) #4
bsalomon
lgtm
7 years, 3 months ago (2013-09-13 19:53:10 UTC) #5
epoger
7 years, 3 months ago (2013-09-13 19:56:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r11265 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698