Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 23889026: Merge 222146 "Delete unneeded pending entries in DidFailProvisio..." (Closed)

Created:
7 years, 3 months ago by Charlie Reis
Modified:
7 years, 3 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, miu+watch_chromium.org
Visibility:
Public.

Description

Merge 222146 "Delete unneeded pending entries in DidFailProvisio..." > Delete unneeded pending entries in DidFailProvisionalLoad to prevent a spoof. > > BUG=280512 > BUG=278899 > TEST=See bug for repro steps. > > Review URL: https://chromiumcodereview.appspot.com/23978003 TBR=creis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -11 lines) Patch
M content/browser/web_contents/navigation_controller_impl.h View 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/web_contents/navigation_controller_impl.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/web_contents/navigation_controller_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +12 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Charlie Reis
7 years, 3 months ago (2013-09-13 17:06:39 UTC) #1
Charlie Reis
7 years, 3 months ago (2013-09-13 17:08:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r223067.

Powered by Google App Engine
This is Rietveld 408576698