Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: sdk/lib/io/directory_impl.dart

Issue 23889008: Move delete/deleteSync up to FileSystemEntity, with a shared documentation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Style fixes. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/directory.dart ('k') | sdk/lib/io/file.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/directory_impl.dart
diff --git a/sdk/lib/io/directory_impl.dart b/sdk/lib/io/directory_impl.dart
index c9eec06376a5df378adebb60dba65149c2a2bbb8..f54a6413c1e938fc9b2d7ef8b85038f9caff18d8 100644
--- a/sdk/lib/io/directory_impl.dart
+++ b/sdk/lib/io/directory_impl.dart
@@ -29,7 +29,7 @@ class _Directory extends FileSystemEntity implements Directory {
external static _createTemp(String template);
external static int _exists(String path);
external static _create(String path);
- external static _delete(String path, bool recursive);
+ external static _deleteNative(String path, bool recursive);
external static _rename(String path, String newPath);
external static List _list(String path, bool recursive, bool followLinks);
external static SendPort _newServicePort();
@@ -183,7 +183,7 @@ class _Directory extends FileSystemEntity implements Directory {
return new Directory(result);
}
- Future<Directory> delete({recursive: false}) {
+ Future<Directory> _delete({recursive: false}) {
_ensureDirectoryService();
List request = new List(3);
request[0] = DELETE_REQUEST;
@@ -197,8 +197,8 @@ class _Directory extends FileSystemEntity implements Directory {
});
}
- void deleteSync({recursive: false}) {
- var result = _delete(path, recursive);
+ void _deleteSync({recursive: false}) {
+ var result = _deleteNative(path, recursive);
if (result is OSError) {
throw new DirectoryException("Deletion failed", path, result);
}
« no previous file with comments | « sdk/lib/io/directory.dart ('k') | sdk/lib/io/file.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698