Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2388853002: Fix vector indexing bug in SerializationUtilsTest.WriteReadTest (Closed)

Created:
4 years, 2 months ago by Ben Chan
Modified:
4 years, 2 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix vector indexing bug in SerializationUtilsTest.WriteReadTest This CL fixes a vector indexing bug in SerializationUtilsTest.WriteReadTest where the code was supposed to ensure that each MetricSample entry in the vector returned by SerializationUtils::ReadAndTruncateMetricsFromFile is not null, instead of just the first entry. BUG=None TEST=component_unittests Committed: https://crrev.com/703959c64ad15ed459edf446914d08d59770119a Cr-Commit-Position: refs/heads/master@{#422628}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/metrics/serialization/serialization_utils_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Ben Chan
4 years, 2 months ago (2016-10-03 15:51:43 UTC) #5
Alexei Svitkine (slow)
lgtm
4 years, 2 months ago (2016-10-03 15:54:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388853002/1
4 years, 2 months ago (2016-10-04 00:23:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 00:31:04 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 00:34:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/703959c64ad15ed459edf446914d08d59770119a
Cr-Commit-Position: refs/heads/master@{#422628}

Powered by Google App Engine
This is Rietveld 408576698