Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2388813002: Delete isWebApkInstalled in ShortcutHelper.java to minimize JNI usage. (Closed)

Created:
4 years, 2 months ago by F
Modified:
4 years, 2 months ago
Reviewers:
pkotwicz, gone
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete isWebApkInstalled in ShortcutHelper.java to minimize JNI usage. This is a follow-up CL to https://codereview.chromium.org/2363183002/. Committed: https://crrev.com/18ea5ddb8a91f2040209d0bdba2b8544863d05d1 Cr-Commit-Position: refs/heads/master@{#422768}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/android/shortcut_helper.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
pkotwicz
lgtm
4 years, 2 months ago (2016-10-03 17:16:37 UTC) #3
F
Hi Dan & Peter, PTAL Thanks!
4 years, 2 months ago (2016-10-03 20:13:33 UTC) #5
gone
lgtm
4 years, 2 months ago (2016-10-03 20:33:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388813002/1
4 years, 2 months ago (2016-10-04 12:18:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 12:49:40 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 12:51:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18ea5ddb8a91f2040209d0bdba2b8544863d05d1
Cr-Commit-Position: refs/heads/master@{#422768}

Powered by Google App Engine
This is Rietveld 408576698