Fix FirstWebContentsProfiler not getting created when using session restore.

Fix FirstWebContentsProfiler not getting created when using session restore.

This regressed in r420175 because a different code path is taken that doesn't go through browser_navigator.cc's CreateTargetContents.

BUG=650349
Committed: https://crrev.com/ede1c0cf9ffbbace44aa77d1bb3c3abc6a460426
Cr-Commit-Position: refs/heads/master@{#422883}

[jam, 2016-10-03 20:34:58]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 20:35:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 21:22:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 21:22:22]

Dry run: This issue passed the CQ dry run.

[jam, 2016-10-03 21:26:17]

jam@chromium.org changed reviewers:
+ gab@chromium.org

[gab, 2016-10-04 19:15:17]

lgtm % comment, thanks!

https://codereview.chromium.org/2388803003/diff/1/chrome/browser/metrics/firs...
File chrome/browser/metrics/first_web_contents_profiler.cc (right):

https://codereview.chromium.org/2388803003/diff/1/chrome/browser/metrics/firs...
chrome/browser/metrics/first_web_contents_profiler.cc:29: new
FirstWebContentsProfiler(web_contents);
// FirstWebContentsProfiler owns itself.

[jam, 2016-10-04 19:18:09]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-10-04 19:18:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-10-04 19:19:17]

https://codereview.chromium.org/2388803003/diff/1/chrome/browser/metrics/firs...
File chrome/browser/metrics/first_web_contents_profiler.cc (right):

https://codereview.chromium.org/2388803003/diff/1/chrome/browser/metrics/firs...
chrome/browser/metrics/first_web_contents_profiler.cc:29: new
FirstWebContentsProfiler(web_contents);
On 2016/10/04 19:15:17, gab wrote:
> // FirstWebContentsProfiler owns itself.

acknowledged, although in this case I think if someone cares knowing ownership
they can easily look at the source. (i.e. i view these kind of comments as
documenting what's obvious)

[commit-bot: I haz the power, 2016-10-04 19:24:35]

Committed patchset #1 (id:1)

[gab, 2016-10-04 19:26:23]

https://codereview.chromium.org/2388803003/diff/1/chrome/browser/metrics/firs...
File chrome/browser/metrics/first_web_contents_profiler.cc (right):

https://codereview.chromium.org/2388803003/diff/1/chrome/browser/metrics/firs...
chrome/browser/metrics/first_web_contents_profiler.cc:29: new
FirstWebContentsProfiler(web_contents);
On 2016/10/04 19:19:17, jam wrote:
> On 2016/10/04 19:15:17, gab wrote:
> > // FirstWebContentsProfiler owns itself.
> 
> acknowledged, although in this case I think if someone cares knowing ownership
> they can easily look at the source. (i.e. i view these kind of comments as
> documenting what's obvious)

okay, I personally find bare "new" surprising and thus like an explicit comment
telling the reader that this was intentional without having to dig further.

[commit-bot: I haz the power, 2016-10-04 19:28:35]

Description was changed from

==========
Fix FirstWebContentsProfiler not getting created when using session restore.

This regressed in r420175 because a different code path is taken that doesn't go
through browser_navigator.cc's CreateTargetContents.

BUG=650349
==========

to

==========
Fix FirstWebContentsProfiler not getting created when using session restore.

This regressed in r420175 because a different code path is taken that doesn't go
through browser_navigator.cc's CreateTargetContents.

BUG=650349

Committed: https://crrev.com/ede1c0cf9ffbbace44aa77d1bb3c3abc6a460426
Cr-Commit-Position: refs/heads/master@{#422883}
==========

[commit-bot: I haz the power, 2016-10-04 19:28:36]

Patchset 1 (id:??) landed as
https://crrev.com/ede1c0cf9ffbbace44aa77d1bb3c3abc6a460426
Cr-Commit-Position: refs/heads/master@{#422883}