Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2388803002:
Remove failed entries and skip Android tests for gpu pixel expectations (Closed)
|
Created:
4 years, 2 months ago by xlai (Olivia) Modified:
4 years, 2 months ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove failed entries and skip Android tests for gpu pixel expectations
The two unaccelerated 2d gpu integration tests are working
fine in Win,Linux and Mac. So I'm removing their failed
entries.
Because software compositing is not supported on Android.
These two tests should not be running on Android platforms.
So I mark them as Skipped.
TBR=kbr@chromium.org
BUG=563852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Committed: https://crrev.com/5280614b9452793b73489cb103cd740ea24f638f
Cr-Commit-Position: refs/heads/master@{#423184}
Patch Set 1 #Patch Set 2 : Still mark android bots as failed #Patch Set 3 : Skip android bots #Patch Set 4 : rebase #Messages
Total messages: 28 (15 generated)
Description was changed from ========== Remove failed entries on gpu pixel expectations TBR=kbr@chromium.org BUG=563852 ========== to ========== Remove failed entries on gpu pixel expectations TBR=kbr@chromium.org BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
The CQ bit was checked by xlai@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
Description was changed from ========== Remove failed entries on gpu pixel expectations TBR=kbr@chromium.org BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Remove failed entries on gpu pixel expectations BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Description was changed from ========== Remove failed entries on gpu pixel expectations BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Remove failed entries on gpu pixel expectations The two unaccelerated 2d gpu integration tests are working fine in Win,Linux and Mac but currently throwing exception on Android. So I mark the failed entries on Android only while debugging on that. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Description was changed from ========== Remove failed entries on gpu pixel expectations The two unaccelerated 2d gpu integration tests are working fine in Win,Linux and Mac but currently throwing exception on Android. So I mark the failed entries on Android only while debugging on that. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Remove failed entries and skip Android tests for gpu pixel expectations The two unaccelerated 2d gpu integration tests are working fine in Win,Linux and Mac. So I'm removing their failed entries. Because software compositing is not supported on Android. These two tests should not be running on Android platforms. So I mark them as Skipped. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Changing title and description.
Description was changed from ========== Remove failed entries and skip Android tests for gpu pixel expectations The two unaccelerated 2d gpu integration tests are working fine in Win,Linux and Mac. So I'm removing their failed entries. Because software compositing is not supported on Android. These two tests should not be running on Android platforms. So I mark them as Skipped. BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Remove failed entries and skip Android tests for gpu pixel expectations The two unaccelerated 2d gpu integration tests are working fine in Win,Linux and Mac. So I'm removing their failed entries. Because software compositing is not supported on Android. These two tests should not be running on Android platforms. So I mark them as Skipped. TBR=kbr@chromium.org BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
The CQ bit was checked by xlai@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
LGTM Let's try again. It would be good if you'd file bugs about the flaky failures if ones aren't already filed.
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
On 2016/10/04 23:17:58, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) Looks like this needs to be rebased?
The CQ bit was checked by xlai@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org Link to the patchset: https://codereview.chromium.org/2388803002/#ps60001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove failed entries and skip Android tests for gpu pixel expectations The two unaccelerated 2d gpu integration tests are working fine in Win,Linux and Mac. So I'm removing their failed entries. Because software compositing is not supported on Android. These two tests should not be running on Android platforms. So I mark them as Skipped. TBR=kbr@chromium.org BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Remove failed entries and skip Android tests for gpu pixel expectations The two unaccelerated 2d gpu integration tests are working fine in Win,Linux and Mac. So I'm removing their failed entries. Because software compositing is not supported on Android. These two tests should not be running on Android platforms. So I mark them as Skipped. TBR=kbr@chromium.org BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Remove failed entries and skip Android tests for gpu pixel expectations The two unaccelerated 2d gpu integration tests are working fine in Win,Linux and Mac. So I'm removing their failed entries. Because software compositing is not supported on Android. These two tests should not be running on Android platforms. So I mark them as Skipped. TBR=kbr@chromium.org BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Remove failed entries and skip Android tests for gpu pixel expectations The two unaccelerated 2d gpu integration tests are working fine in Win,Linux and Mac. So I'm removing their failed entries. Because software compositing is not supported on Android. These two tests should not be running on Android platforms. So I mark them as Skipped. TBR=kbr@chromium.org BUG=563852 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/5280614b9452793b73489cb103cd740ea24f638f Cr-Commit-Position: refs/heads/master@{#423184} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/5280614b9452793b73489cb103cd740ea24f638f Cr-Commit-Position: refs/heads/master@{#423184} |
