Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2388793005: Support 3+ panels in the OverlayPanelManager (Closed)

Created:
4 years, 2 months ago by mdjones
Modified:
4 years, 2 months ago
Reviewers:
Theresa, Donn Denman
CC:
chromium-reviews, mdjones+watch_chromium.org, donnd+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support 3+ panels in the OverlayPanelManager BUG= Committed: https://crrev.com/a6ceab457fb943607c7e8d597f6d69c145cee699 Cr-Commit-Position: refs/heads/master@{#422964}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelManager.java View 1 10 chunks +33 lines, -11 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelManagerTest.java View 1 chunk +78 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mdjones
ptal
4 years, 2 months ago (2016-10-04 18:55:08 UTC) #2
Theresa
lgtm
4 years, 2 months ago (2016-10-04 20:06:34 UTC) #3
Donn Denman
LGTM, just one optional nit. https://codereview.chromium.org/2388793005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelManager.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelManager.java (right): https://codereview.chromium.org/2388793005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelManager.java#newcode154 chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelManager.java:154: * Get the size ...
4 years, 2 months ago (2016-10-04 21:00:04 UTC) #4
mdjones
https://codereview.chromium.org/2388793005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelManager.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelManager.java (right): https://codereview.chromium.org/2388793005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelManager.java#newcode154 chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelManager.java:154: * Get the size of the queue of suppressed ...
4 years, 2 months ago (2016-10-04 21:24:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388793005/20001
4 years, 2 months ago (2016-10-04 21:25:17 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 22:21:52 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 22:25:36 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a6ceab457fb943607c7e8d597f6d69c145cee699
Cr-Commit-Position: refs/heads/master@{#422964}

Powered by Google App Engine
This is Rietveld 408576698