Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: media/base/mime_util_internal.cc

Issue 2388793003: Make CanPlayType("vp9.2") return true (Closed)
Patch Set: formatted Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/mime_util_internal.cc
diff --git a/media/base/mime_util_internal.cc b/media/base/mime_util_internal.cc
index 11a763e74ab3c0054e6a39db8a3bcdbac462b19b..2416478b8fb489f0b3c41305215f1c54d98bfe01 100644
--- a/media/base/mime_util_internal.cc
+++ b/media/base/mime_util_internal.cc
@@ -718,6 +718,14 @@ bool MimeUtil::StringToCodec(const std::string& mime_type_lower_case,
// Profile 0 should always be supported if VP9 is supported.
*is_ambiguous = false;
break;
+#if defined(ARCH_CPU_X86_FAMILY) && !defined(OS_ANDROID)
ddorwin 2016/10/04 00:43:13 Will we not fall back to libvpx on Android if the
ddorwin 2016/10/04 00:43:13 You might mention that this is because libvpx supp
+ // Profile 1 & 2 are always supported on X86, at least for
ddorwin 2016/10/04 00:43:13 Please update the browser tests.
+ // unencrypted videos.
+ case VP9PROFILE_PROFILE1:
ddorwin 2016/10/04 00:43:13 The description does not cover this.
+ case VP9PROFILE_PROFILE2:
+ if (is_encrypted)
+ *is_ambiguous = true;
+#endif
ddorwin 2016/10/04 00:43:13 break;
default:
// We don't know if the underlying platform supports these profiles.
// Need to add platform level querying to get supported profiles
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698