Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2388793003: Make CanPlayType("vp9.2") return true (Closed)

Created:
4 years, 2 months ago by hubbe
Modified:
3 years, 9 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make CanPlayType("vp9.2") return true ... at least on x86 platforms and for non-encrypted videos. BUG=445071

Patch Set 1 #

Patch Set 2 : formatted #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M media/base/mime_util_internal.cc View 1 1 chunk +8 lines, -0 lines 6 comments Download

Messages

Total messages: 12 (10 generated)
hubbe
4 years, 2 months ago (2016-10-03 22:30:33 UTC) #8
ddorwin
4 years, 2 months ago (2016-10-04 00:43:14 UTC) #11
https://codereview.chromium.org/2388793003/diff/20001/media/base/mime_util_in...
File media/base/mime_util_internal.cc (right):

https://codereview.chromium.org/2388793003/diff/20001/media/base/mime_util_in...
media/base/mime_util_internal.cc:159: if (codec_id == "vp9" || codec_id ==
"vp9.0") {
This CL does not do what the description says. "vp9.2" would only be supported
in WebM (MP4 starts with "vp09"), but that is not allowed here.

Also, there is an open question of how to specify other profiles (and additional
information, as supported for MP4 below) in WebM.

https://codereview.chromium.org/2388793003/diff/20001/media/base/mime_util_in...
media/base/mime_util_internal.cc:721: #if defined(ARCH_CPU_X86_FAMILY) &&
!defined(OS_ANDROID)
You might mention that this is because libvpx supports it in the comment below.

https://codereview.chromium.org/2388793003/diff/20001/media/base/mime_util_in...
media/base/mime_util_internal.cc:721: #if defined(ARCH_CPU_X86_FAMILY) &&
!defined(OS_ANDROID)
Will we not fall back to libvpx on Android if the platform decoder does not
support profile 2?

https://codereview.chromium.org/2388793003/diff/20001/media/base/mime_util_in...
media/base/mime_util_internal.cc:722: // Profile 1 & 2 are always supported on
X86, at least for
Please update the browser tests.

https://codereview.chromium.org/2388793003/diff/20001/media/base/mime_util_in...
media/base/mime_util_internal.cc:724: case VP9PROFILE_PROFILE1:
The description does not cover this.

https://codereview.chromium.org/2388793003/diff/20001/media/base/mime_util_in...
media/base/mime_util_internal.cc:728: #endif
break;

Powered by Google App Engine
This is Rietveld 408576698