Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: ios/chrome/browser/ntp_tiles/ios_most_visited_sites_factory.cc

Issue 2388783004: Ensure PopularSite icon availability in ntp_tiles. (Closed)
Patch Set: Merge branch 'master' into icons Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_tiles/popular_sites.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ntp_tiles/ios_most_visited_sites_factory.cc
diff --git a/ios/chrome/browser/ntp_tiles/ios_most_visited_sites_factory.cc b/ios/chrome/browser/ntp_tiles/ios_most_visited_sites_factory.cc
index 696c07383c810a4eb631313555b298de10054faa..ecca8521d73088c2310ffaa7e7a9138833f83750 100644
--- a/ios/chrome/browser/ntp_tiles/ios_most_visited_sites_factory.cc
+++ b/ios/chrome/browser/ntp_tiles/ios_most_visited_sites_factory.cc
@@ -6,18 +6,36 @@
#include "base/memory/ptr_util.h"
#include "components/history/core/browser/top_sites.h"
+#include "components/image_fetcher/image_fetcher_impl.h"
+#include "components/keyed_service/core/service_access_type.h"
+#include "components/ntp_tiles/icon_cacher.h"
#include "components/ntp_tiles/most_visited_sites.h"
#include "ios/chrome/browser/browser_state/chrome_browser_state.h"
+#include "ios/chrome/browser/favicon/favicon_service_factory.h"
#include "ios/chrome/browser/history/top_sites_factory.h"
#include "ios/chrome/browser/ntp_tiles/ios_popular_sites_factory.h"
+#include "ios/chrome/browser/suggestions/ios_image_decoder_impl.h"
#include "ios/chrome/browser/suggestions/suggestions_service_factory.h"
+#include "ios/web/public/web_thread.h"
std::unique_ptr<ntp_tiles::MostVisitedSites>
IOSMostVisitedSitesFactory::NewForBrowserState(
ios::ChromeBrowserState* browser_state) {
+ scoped_refptr<base::SequencedTaskRunner> task_runner =
+ web::WebThread::GetBlockingPool()
+ ->GetSequencedTaskRunnerWithShutdownBehavior(
+ base::SequencedWorkerPool::GetSequenceToken(),
+ base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN);
return base::MakeUnique<ntp_tiles::MostVisitedSites>(
browser_state->GetPrefs(),
ios::TopSitesFactory::GetForBrowserState(browser_state),
suggestions::SuggestionsServiceFactory::GetForBrowserState(browser_state),
- IOSPopularSitesFactory::NewForBrowserState(browser_state), nil);
+ IOSPopularSitesFactory::NewForBrowserState(browser_state),
+ base::MakeUnique<ntp_tiles::IconCacher>(
+ ios::FaviconServiceFactory::GetForBrowserState(
+ browser_state, ServiceAccessType::IMPLICIT_ACCESS),
+ base::MakeUnique<image_fetcher::ImageFetcherImpl>(
+ suggestions::CreateIOSImageDecoder(task_runner),
+ browser_state->GetRequestContext())),
+ nil);
}
« no previous file with comments | « components/ntp_tiles/popular_sites.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698