Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: components/ntp_tiles/icon_cacher.h

Issue 2388783004: Ensure PopularSite icon availability in ntp_tiles. (Closed)
Patch Set: Fetch popular site icons only when needed. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_tiles/icon_cacher.h
diff --git a/components/ntp_tiles/icon_cacher.h b/components/ntp_tiles/icon_cacher.h
new file mode 100644
index 0000000000000000000000000000000000000000..8d1e2f641d066cc63a69626df79eede008e36b6e
--- /dev/null
+++ b/components/ntp_tiles/icon_cacher.h
@@ -0,0 +1,68 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_NTP_TILES_ICON_CACHER_H_
+#define COMPONENTS_NTP_TILES_ICON_CACHER_H_
+
+#include <memory>
+
+#include "base/callback.h"
+#include "base/memory/weak_ptr.h"
+#include "base/task/cancelable_task_tracker.h"
+#include "components/ntp_tiles/popular_sites.h"
+
+namespace favicon {
+class FaviconService;
+} // namespace favicon
+
+namespace favicon_base {
+struct FaviconImageResult;
+} // namespace favicon_base
+
+namespace gfx {
+class Image;
+} // namespace gfx
+
+namespace image_fetcher {
+class ImageFetcher;
+} // namespace image_fetcher
+
+namespace ntp_tiles {
+
+// Ensures that a Popular Sites icon is cached, downloading and saving it if
+// not.
+//
+// Does not provide any way to get a fetched favicon; use the FaviconService for
+// that. All this class does is guarantee that FaviconService will be able to
+// get you an icon (if it exists).
+class IconCacher {
+ public:
+ IconCacher(favicon::FaviconService* favicon_service,
+ std::unique_ptr<image_fetcher::ImageFetcher> image_fetcher);
+ ~IconCacher();
+
+ // Fetches the icon if necessary, then invokes |done| with true if it was
+ // newly fetched (false if it was already cached or could not be fetched).
+ void StartFetch(PopularSites::Site site,
+ const base::Callback<void(bool)>& done);
+
+ private:
+ void OnGetFaviconImageForPageURLFinished(
+ PopularSites::Site site,
+ const base::Callback<void(bool)>& done,
+ const favicon_base::FaviconImageResult& result);
+
+ void OnFaviconDownloaded(PopularSites::Site site,
+ const base::Callback<void(bool)>& done,
+ const std::string& id,
+ const gfx::Image& fetched_image);
+
+ base::CancelableTaskTracker tracker_;
+ favicon::FaviconService* const favicon_service_;
+ std::unique_ptr<image_fetcher::ImageFetcher> const image_fetcher_;
+};
Bernhard Bauer 2016/10/13 13:20:09 DISALLOW_COPY_AND_ASSIGN
sfiera 2016/10/14 06:27:32 Done.
+
+} // namespace ntp_tiles
+
+#endif // COMPONENTS_NTP_TILES_ICON_CACHER_H_

Powered by Google App Engine
This is Rietveld 408576698