Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: components/ntp_tiles/BUILD.gn

Issue 2388783004: Ensure PopularSite icon availability in ntp_tiles. (Closed)
Patch Set: Fix comments, variable names. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_tiles/BUILD.gn
diff --git a/components/ntp_tiles/BUILD.gn b/components/ntp_tiles/BUILD.gn
index e51074fe2d08f4eb123b9e41cf1b240e81012ebc..c1493daebba57f1156d40269c2c26b53a480accd 100644
--- a/components/ntp_tiles/BUILD.gn
+++ b/components/ntp_tiles/BUILD.gn
@@ -10,6 +10,8 @@ static_library("ntp_tiles") {
sources = [
"constants.cc",
"constants.h",
+ "icon_cacher.cc",
+ "icon_cacher.h",
"most_visited_sites.cc",
"most_visited_sites.h",
"ntp_tile.cc",
@@ -29,7 +31,10 @@ static_library("ntp_tiles") {
]
deps = [
"//components/data_use_measurement/core",
+ "//components/favicon/core",
+ "//components/favicon_base",
"//components/google/core/browser",
+ "//components/image_fetcher",
"//components/pref_registry",
"//components/prefs",
"//components/search_engines",
@@ -45,12 +50,18 @@ static_library("ntp_tiles") {
source_set("unit_tests") {
testonly = true
sources = [
+ "icon_cacher_unittest.cc",
"most_visited_sites_unittest.cc",
]
deps = [
":ntp_tiles",
+ "//components/favicon/core",
+ "//components/favicon_base",
+ "//components/image_fetcher",
+ "//testing/gmock",
"//testing/gtest",
+ "//ui/gfx:test_support",
]
}

Powered by Google App Engine
This is Rietveld 408576698