Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4867)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2388783004: Ensure PopularSite icon availability in ntp_tiles. (Closed)
Patch Set: Fix comments, variable names. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
index a30e5624a0d919c6c31cafeb39596199bf4684c5..d150cfabdcb517b117ea8b2eed9cc66d3c55938b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
@@ -1021,27 +1021,8 @@ public class NewTabPageView extends FrameLayout
}
@Override
- public void onPopularURLsAvailable(
- String[] urls, String[] faviconUrls, String[] largeIconUrls) {
- for (int i = 0; i < urls.length; i++) {
- final String url = urls[i];
- boolean useLargeIcon = !largeIconUrls[i].isEmpty();
- // Only fetch one of favicon or large icon based on what is required on the NTP.
- // The other will be fetched on visiting the site.
- String iconUrl = useLargeIcon ? largeIconUrls[i] : faviconUrls[i];
- if (iconUrl.isEmpty()) continue;
-
- IconAvailabilityCallback callback = new IconAvailabilityCallback() {
- @Override
- public void onIconAvailabilityChecked(boolean newlyAvailable) {
- if (newlyAvailable) {
- mMostVisitedDesign.onIconUpdated(url);
- }
- }
- };
- mManager.ensureIconIsAvailable(
- url, iconUrl, useLargeIcon, /*isTemporary=*/false, callback);
- }
+ public void onIconMadeAvailable(String siteUrl) {
+ mMostVisitedDesign.onIconUpdated(siteUrl);
}
/**

Powered by Google App Engine
This is Rietveld 408576698