Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Side by Side Diff: components/ntp_tiles/BUILD.gn

Issue 2388783004: Ensure PopularSite icon availability in ntp_tiles. (Closed)
Patch Set: Fix comments, variable names. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/rules.gni") 6 import("//build/config/android/rules.gni")
7 } 7 }
8 8
9 static_library("ntp_tiles") { 9 static_library("ntp_tiles") {
10 sources = [ 10 sources = [
11 "constants.cc", 11 "constants.cc",
12 "constants.h", 12 "constants.h",
13 "icon_cacher.cc",
14 "icon_cacher.h",
13 "most_visited_sites.cc", 15 "most_visited_sites.cc",
14 "most_visited_sites.h", 16 "most_visited_sites.h",
15 "ntp_tile.cc", 17 "ntp_tile.cc",
16 "ntp_tile.h", 18 "ntp_tile.h",
17 "popular_sites.cc", 19 "popular_sites.cc",
18 "popular_sites.h", 20 "popular_sites.h",
19 "pref_names.cc", 21 "pref_names.cc",
20 "pref_names.h", 22 "pref_names.h",
21 "switches.cc", 23 "switches.cc",
22 "switches.h", 24 "switches.h",
23 ] 25 ]
24 26
25 public_deps = [ 27 public_deps = [
26 "//base", 28 "//base",
27 "//components/history/core/browser", 29 "//components/history/core/browser",
28 "//components/suggestions", 30 "//components/suggestions",
29 ] 31 ]
30 deps = [ 32 deps = [
31 "//components/data_use_measurement/core", 33 "//components/data_use_measurement/core",
34 "//components/favicon/core",
35 "//components/favicon_base",
32 "//components/google/core/browser", 36 "//components/google/core/browser",
37 "//components/image_fetcher",
33 "//components/pref_registry", 38 "//components/pref_registry",
34 "//components/prefs", 39 "//components/prefs",
35 "//components/search_engines", 40 "//components/search_engines",
36 "//components/variations", 41 "//components/variations",
37 "//components/variations/service", 42 "//components/variations/service",
38 ] 43 ]
39 44
40 if (is_android) { 45 if (is_android) {
41 deps += [ "android:ntp_tiles_jni_headers" ] 46 deps += [ "android:ntp_tiles_jni_headers" ]
42 } 47 }
43 } 48 }
44 49
45 source_set("unit_tests") { 50 source_set("unit_tests") {
46 testonly = true 51 testonly = true
47 sources = [ 52 sources = [
53 "icon_cacher_unittest.cc",
48 "most_visited_sites_unittest.cc", 54 "most_visited_sites_unittest.cc",
49 ] 55 ]
50 56
51 deps = [ 57 deps = [
52 ":ntp_tiles", 58 ":ntp_tiles",
59 "//components/favicon/core",
60 "//components/favicon_base",
61 "//components/image_fetcher",
62 "//testing/gmock",
53 "//testing/gtest", 63 "//testing/gtest",
64 "//ui/gfx:test_support",
54 ] 65 ]
55 } 66 }
56 67
57 if (is_android) { 68 if (is_android) {
58 java_cpp_enum("ntp_tiles_enums_java") { 69 java_cpp_enum("ntp_tiles_enums_java") {
59 sources = [ 70 sources = [
60 "most_visited_sites.h", 71 "most_visited_sites.h",
61 "ntp_tile.h", 72 "ntp_tile.h",
62 ] 73 ]
63 } 74 }
64 } 75 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698