chrome: remove --disable-async-dns switch

chrome: remove --disable-async-dns switch

It's not something we want permanently set via about:flags. We'll enable it for
debugging via net-internals.

BUG=344544
TEST=passing --disable-async-dns to chrome does nothing anymore
R=thestig@chromium.org,mmenke@chromium.org

Committed: https://crrev.com/11d2325572be9059268cac5d8ae064d19b488358
Cr-Commit-Position: refs/heads/master@{#422908}

[tfarina, 2016-10-03 17:26:52]

The CQ bit was checked by tfarina@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 17:27:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tfarina, 2016-10-03 17:35:29]

Please, take a look when you have spare time.

https://codereview.chromium.org/2388783003/diff/1/chrome/browser/prefs/comman...
File chrome/browser/prefs/command_line_pref_store.cc (left):

https://codereview.chromium.org/2388783003/diff/1/chrome/browser/prefs/comman...
chrome/browser/prefs/command_line_pref_store.cc:78: {switches::kDisableAsyncDns,
prefs::kBuiltInDnsClientEnabled, false},
Do I need to remove kBuiltInDnsClientEnabled as well? I feel like I'm missing
something.

[commit-bot: I haz the power, 2016-10-03 18:23:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 18:23:11]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-10-03 20:40:51]

I defer to mmenke@.

[mmenke, 2016-10-04 15:14:42]

mmenke@chromium.org changed reviewers:
+ juliatuttle@chromium.org

[mmenke, 2016-10-04 15:14:42]

[+juliatuttle], who owns the DNS stuff (And whom I defer to).

I think we want to keep the group policy to disable async DNS, which means
keeping the prefs stuff, or am I wrong, Julia?

[Julia Tuttle, 2016-10-04 15:15:46]

On 2016/10/04 15:14:42, mmenke wrote:
> [+juliatuttle], who owns the DNS stuff (And whom I defer to).
> 
> I think we want to keep the group policy to disable async DNS, which means
> keeping the prefs stuff, or am I wrong, Julia?

I do believe we want to keep the group policy. I am not sure if that requires
keeping the prefs stuff.

[mmenke, 2016-10-04 15:17:50]

On 2016/10/04 15:15:46, Julia Tuttle wrote:
> On 2016/10/04 15:14:42, mmenke wrote:
> > [+juliatuttle], who owns the DNS stuff (And whom I defer to).
> > 
> > I think we want to keep the group policy to disable async DNS, which means
> > keeping the prefs stuff, or am I wrong, Julia?
> 
> I do believe we want to keep the group policy. I am not sure if that requires
> keeping the prefs stuff.

LGTM. My understanding is the policy sets the pref.  
https://cs.chromium.org/chromium/src/chrome/browser/policy/configuration_poli...
is the code that ties them together.

[Lei Zhang, 2016-10-04 17:52:19]

rs lgtm

[tfarina, 2016-10-04 19:39:11]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2016-10-04 19:39:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 20:28:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-04 20:31:18]

Description was changed from

==========
chrome: remove --disable-async-dns switch

It's not something we want permanently set via about:flags. We'll enable it for
debugging via net-internals.

BUG=344544
TEST=passing --disable-async-dns to chrome does nothing anymore
R=thestig@chromium.org,mmenke@chromium.org
==========

to

==========
chrome: remove --disable-async-dns switch

It's not something we want permanently set via about:flags. We'll enable it for
debugging via net-internals.

BUG=344544
TEST=passing --disable-async-dns to chrome does nothing anymore
R=thestig@chromium.org,mmenke@chromium.org

Committed: https://crrev.com/11d2325572be9059268cac5d8ae064d19b488358
Cr-Commit-Position: refs/heads/master@{#422908}
==========

[commit-bot: I haz the power, 2016-10-04 20:31:18]

Patchset 1 (id:??) landed as
https://crrev.com/11d2325572be9059268cac5d8ae064d19b488358
Cr-Commit-Position: refs/heads/master@{#422908}