Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Side by Side Diff: chrome/browser/resources/feedback/js/event_handler.js

Issue 2388773002: feedback: fix buttons overlapping text in long-text locales (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/feedback/html/default.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 <include src="data.js"> 5 <include src="data.js">
6 6
7 /** 7 /**
8 * @type {number} 8 * @type {number}
9 * @const 9 * @const
10 */ 10 */
11 var FEEDBACK_WIDTH = 500; 11 var FEEDBACK_WIDTH = 500;
12 /** 12 /**
13 * @type {number} 13 * @type {number}
14 * @const 14 * @const
15 */ 15 */
16 var FEEDBACK_HEIGHT = 585; 16 var FEEDBACK_HEIGHT = 610;
17 17
18 /** 18 /**
19 * @type {string} 19 * @type {string}
20 * @const 20 * @const
21 */ 21 */
22 var FEEDBACK_DEFAULT_WINDOW_ID = 'default_window'; 22 var FEEDBACK_DEFAULT_WINDOW_ID = 'default_window';
23 23
24 // To generate a hashed extension ID, use a sha-1 hash, all in lower case. 24 // To generate a hashed extension ID, use a sha-1 hash, all in lower case.
25 // Example: 25 // Example:
26 // echo -n 'abcdefghijklmnopqrstuvwxyzabcdef' | sha1sum | \ 26 // echo -n 'abcdefghijklmnopqrstuvwxyzabcdef' | sha1sum | \
(...skipping 268 matching lines...) Expand 10 before | Expand all | Expand 10 after
295 // Observe when the window is closed. 295 // Observe when the window is closed.
296 appWindow.onClosed.addListener(function() { 296 appWindow.onClosed.addListener(function() {
297 request.onWindowClosed(); 297 request.onWindowClosed();
298 }); 298 });
299 }); 299 });
300 } 300 }
301 301
302 chrome.runtime.onMessage.addListener(feedbackReadyHandler); 302 chrome.runtime.onMessage.addListener(feedbackReadyHandler);
303 chrome.runtime.onMessageExternal.addListener(requestFeedbackHandler); 303 chrome.runtime.onMessageExternal.addListener(requestFeedbackHandler);
304 chrome.feedbackPrivate.onFeedbackRequested.addListener(startFeedbackUI); 304 chrome.feedbackPrivate.onFeedbackRequested.addListener(startFeedbackUI);
OLDNEW
« no previous file with comments | « chrome/browser/resources/feedback/html/default.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698