feedback: fix buttons overlapping text in long-text locales

feedback: fix buttons overlapping text in long-text locales

Since the ok/cancel buttons had "position: absolute", they would be positioned
over the privacy text if the privacy text happened to be longer than it is in
English. This change:

1) Makes the bottom buttons not use "position: absolute", which seems like it
   was only intended to apply to the "window control" buttons;
2) Makes the dialog taller, since the non-absolute buttons now can't overlap
   the text, which they previously did to save height.

Note that this design is still fairly brittle; if locales have a much shorter
privacy text, there'll be significant whitespace between the text and the
bottom buttons, and if a locale has much longer text, the dialog will gain a
scroll bar, which looks pretty ugly.

BUG=650978
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a8a4af9d344cb3ff20caa5f07c4f69903dec88bf
Cr-Commit-Position: refs/heads/master@{#423148}

[Elly Fong-Jones, 2016-10-03 13:08:42]

Description was changed from

==========
feedback: fix buttons overlapping text in long-text locales

Since the ok/cancel buttons had "position: absolute", they would be positioned
over the privacy text if the privacy text happened to be longer than it is in
English. This change:

1) Makes the bottom buttons not use "position: absolute", which seems like it
   was only intended to apply to the "window control" buttons;
2) Makes the dialog taller, since the non-absolute buttons now can't overlap
   the text, which they previously did to save height.

Note that this design is still fairly brittle; if locales have a much shorter
privacy text, there'll be significant whitespace between the text and the
bottom buttons, and if a locale has much longer text, the dialog will gain a
scroll bar, which looks pretty ugly.

BUG=650978
==========

to

==========
feedback: fix buttons overlapping text in long-text locales

Since the ok/cancel buttons had "position: absolute", they would be positioned
over the privacy text if the privacy text happened to be longer than it is in
English. This change:

1) Makes the bottom buttons not use "position: absolute", which seems like it
   was only intended to apply to the "window control" buttons;
2) Makes the dialog taller, since the non-absolute buttons now can't overlap
   the text, which they previously did to save height.

Note that this design is still fairly brittle; if locales have a much shorter
privacy text, there'll be significant whitespace between the text and the
bottom buttons, and if a locale has much longer text, the dialog will gain a
scroll bar, which looks pretty ugly.

BUG=650978
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Elly Fong-Jones, 2016-10-03 13:09:03]

Description was changed from

==========
feedback: fix buttons overlapping text in long-text locales

Since the ok/cancel buttons had "position: absolute", they would be positioned
over the privacy text if the privacy text happened to be longer than it is in
English. This change:

1) Makes the bottom buttons not use "position: absolute", which seems like it
   was only intended to apply to the "window control" buttons;
2) Makes the dialog taller, since the non-absolute buttons now can't overlap
   the text, which they previously did to save height.

Note that this design is still fairly brittle; if locales have a much shorter
privacy text, there'll be significant whitespace between the text and the
bottom buttons, and if a locale has much longer text, the dialog will gain a
scroll bar, which looks pretty ugly.

BUG=650978
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
feedback: fix buttons overlapping text in long-text locales

Since the ok/cancel buttons had "position: absolute", they would be positioned
over the privacy text if the privacy text happened to be longer than it is in
English. This change:

1) Makes the bottom buttons not use "position: absolute", which seems like it
   was only intended to apply to the "window control" buttons;
2) Makes the dialog taller, since the non-absolute buttons now can't overlap
   the text, which they previously did to save height.

Note that this design is still fairly brittle; if locales have a much shorter
privacy text, there'll be significant whitespace between the text and the
bottom buttons, and if a locale has much longer text, the dialog will gain a
scroll bar, which looks pretty ugly.

BUG=650978
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Elly Fong-Jones, 2016-10-03 13:09:03]

ellyjones@chromium.org changed reviewers:
+ afakhry@chromium.org

[Elly Fong-Jones, 2016-10-03 13:09:12]

afakhry: ptal?

[afakhry, 2016-10-04 21:39:45]

lgtm

[Elly Fong-Jones, 2016-10-05 11:55:05]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-10-05 11:55:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 13:54:01]

Description was changed from

==========
feedback: fix buttons overlapping text in long-text locales

Since the ok/cancel buttons had "position: absolute", they would be positioned
over the privacy text if the privacy text happened to be longer than it is in
English. This change:

1) Makes the bottom buttons not use "position: absolute", which seems like it
   was only intended to apply to the "window control" buttons;
2) Makes the dialog taller, since the non-absolute buttons now can't overlap
   the text, which they previously did to save height.

Note that this design is still fairly brittle; if locales have a much shorter
privacy text, there'll be significant whitespace between the text and the
bottom buttons, and if a locale has much longer text, the dialog will gain a
scroll bar, which looks pretty ugly.

BUG=650978
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
feedback: fix buttons overlapping text in long-text locales

Since the ok/cancel buttons had "position: absolute", they would be positioned
over the privacy text if the privacy text happened to be longer than it is in
English. This change:

1) Makes the bottom buttons not use "position: absolute", which seems like it
   was only intended to apply to the "window control" buttons;
2) Makes the dialog taller, since the non-absolute buttons now can't overlap
   the text, which they previously did to save height.

Note that this design is still fairly brittle; if locales have a much shorter
privacy text, there'll be significant whitespace between the text and the
bottom buttons, and if a locale has much longer text, the dialog will gain a
scroll bar, which looks pretty ugly.

BUG=650978
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-05 13:54:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-05 13:57:05]

Description was changed from

==========
feedback: fix buttons overlapping text in long-text locales

Since the ok/cancel buttons had "position: absolute", they would be positioned
over the privacy text if the privacy text happened to be longer than it is in
English. This change:

1) Makes the bottom buttons not use "position: absolute", which seems like it
   was only intended to apply to the "window control" buttons;
2) Makes the dialog taller, since the non-absolute buttons now can't overlap
   the text, which they previously did to save height.

Note that this design is still fairly brittle; if locales have a much shorter
privacy text, there'll be significant whitespace between the text and the
bottom buttons, and if a locale has much longer text, the dialog will gain a
scroll bar, which looks pretty ugly.

BUG=650978
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
feedback: fix buttons overlapping text in long-text locales

Since the ok/cancel buttons had "position: absolute", they would be positioned
over the privacy text if the privacy text happened to be longer than it is in
English. This change:

1) Makes the bottom buttons not use "position: absolute", which seems like it
   was only intended to apply to the "window control" buttons;
2) Makes the dialog taller, since the non-absolute buttons now can't overlap
   the text, which they previously did to save height.

Note that this design is still fairly brittle; if locales have a much shorter
privacy text, there'll be significant whitespace between the text and the
bottom buttons, and if a locale has much longer text, the dialog will gain a
scroll bar, which looks pretty ugly.

BUG=650978
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a8a4af9d344cb3ff20caa5f07c4f69903dec88bf
Cr-Commit-Position: refs/heads/master@{#423148}
==========

[commit-bot: I haz the power, 2016-10-05 13:57:07]

Patchset 1 (id:??) landed as
https://crrev.com/a8a4af9d344cb3ff20caa5f07c4f69903dec88bf
Cr-Commit-Position: refs/heads/master@{#423148}