Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: content/browser/frame_host/render_widget_host_view_guest_unittest.cc

Issue 2388753003: Introduce cc::LocalFrameId and use in SurfaceFactory (Closed)
Patch Set: Fix exo_unittests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_guest_unittest.cc
diff --git a/content/browser/frame_host/render_widget_host_view_guest_unittest.cc b/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
index 6946b4ef8604d872f21689b6919371b0a612dd4a..95003452a264e4a8ddc76fee7695f8745cf13486 100644
--- a/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
+++ b/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
@@ -212,9 +212,13 @@ class RenderWidgetHostViewGuestSurfaceTest
#endif
}
- cc::SurfaceId surface_id() {
+ cc::SurfaceId GetSurfaceId() const {
DCHECK(view_);
- return static_cast<RenderWidgetHostViewChildFrame*>(view_)->surface_id_;
+ RenderWidgetHostViewChildFrame* rwhvcf =
+ static_cast<RenderWidgetHostViewChildFrame*>(view_);
+ if (rwhvcf->local_frame_id_.is_null())
+ return cc::SurfaceId();
+ return cc::SurfaceId(rwhvcf->frame_sink_id_, rwhvcf->local_frame_id_);
}
protected:
@@ -268,7 +272,7 @@ TEST_F(RenderWidgetHostViewGuestSurfaceTest, TestGuestSurface) {
view_->OnSwapCompositorFrame(
0, CreateDelegatedFrame(scale_factor, view_size, view_rect));
- cc::SurfaceId id = surface_id();
+ cc::SurfaceId id = GetSurfaceId();
if (!id.is_null()) {
#if !defined(OS_ANDROID)
ImageTransportFactory* factory = ImageTransportFactory::GetInstance();
@@ -291,7 +295,7 @@ TEST_F(RenderWidgetHostViewGuestSurfaceTest, TestGuestSurface) {
view_->OnSwapCompositorFrame(
0, CreateDelegatedFrame(scale_factor, view_size, view_rect));
- id = surface_id();
+ id = GetSurfaceId();
if (!id.is_null()) {
#if !defined(OS_ANDROID)
ImageTransportFactory* factory = ImageTransportFactory::GetInstance();
@@ -314,7 +318,7 @@ TEST_F(RenderWidgetHostViewGuestSurfaceTest, TestGuestSurface) {
view_->OnSwapCompositorFrame(
0, CreateDelegatedFrame(scale_factor, view_size, view_rect));
- EXPECT_TRUE(surface_id().is_null());
+ EXPECT_TRUE(GetSurfaceId().is_null());
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698