Header cleanup: don't include system header stdio.h in non-debug builds

Header cleanup: don't leak system header stdio.h in non-debug builds

Clean the inclusion of stdio.h in wtf and core components. Include the system header in debug builds only if required. Remove any unwanted inclusions.

BUG=NONE

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157343

[Nico, 2013-09-03 15:55:14]

Looks mostly fine, though I'm not sure if the #ifndef NDEBUG includes are worth
it as it's likely that something else pulls in stdio.h already. I guess it's
fine.

https://codereview.chromium.org/23887002/diff/1/Source/weborigin/KURL.cpp
File Source/weborigin/KURL.cpp (right):

https://codereview.chromium.org/23887002/diff/1/Source/weborigin/KURL.cpp#new...
Source/weborigin/KURL.cpp:634: printf("%s\n", m_string.utf8().data());
This requires stdio.h.

(fprintf(stderr, …) would be better due to no buffering tho)

https://codereview.chromium.org/23887002/diff/1/Source/wtf/PrintStream.cpp
File Source/wtf/PrintStream.cpp (right):

https://codereview.chromium.org/23887002/diff/1/Source/wtf/PrintStream.cpp#ne...
Source/wtf/PrintStream.cpp:41: vprintf(format, argList);
this requires stdio.h

[r.kasibhatla, 2013-09-04 05:19:23]

On 2013/09/03 15:55:14, Nico wrote:
> Looks mostly fine, though I'm not sure if the #ifndef NDEBUG includes are
worth
> it as it's likely that something else pulls in stdio.h already. I guess it's
> fine.
I agree but my idea behind putting the header in NDEBUG was to clear send the
message that the header has been included specifically for some changes which
are meant only for debug builds.
> 
> https://codereview.chromium.org/23887002/diff/1/Source/weborigin/KURL.cpp
> File Source/weborigin/KURL.cpp (right):
> 
>
https://codereview.chromium.org/23887002/diff/1/Source/weborigin/KURL.cpp#new...
> Source/weborigin/KURL.cpp:634: printf("%s\n", m_string.utf8().data());
> This requires stdio.h.
> 
> (fprintf(stderr, …) would be better due to no buffering tho)
> 
> https://codereview.chromium.org/23887002/diff/1/Source/wtf/PrintStream.cpp
> File Source/wtf/PrintStream.cpp (right):
> 
>
https://codereview.chromium.org/23887002/diff/1/Source/wtf/PrintStream.cpp#ne...
> Source/wtf/PrintStream.cpp:41: vprintf(format, argList);
> this requires stdio.h
These 2 files are an example of your previous comment. Though I removed stdio.h,
they still compile properly since stdio.h is getting included from other
headers. However, still I restored the inclusion as needed.

[Nico, 2013-09-05 04:07:28]

lgtm

[Chris Evans, 2013-09-05 04:10:17]

On 2013/09/05 04:07:28, Nico wrote:
> lgtm

(Thanks for doing this. If you're looking to do additional work in this area,
the best benefits are achieved from eliminating unneccessary headers from .h
files)

[r.kasibhatla, 2013-09-05 04:28:27]

On 2013/09/05 04:10:17, Chris Evans wrote:
> On 2013/09/05 04:07:28, Nico wrote:
> > lgtm
> 
> (Thanks for doing this. If you're looking to do additional work in this area,
> the best benefits are achieved from eliminating unneccessary headers from .h
> files)
Yes, I am further looking into cleaning up the headers.

[commit-bot: I haz the power, 2013-09-05 05:09:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/23887002/7001

[commit-bot: I haz the power, 2013-09-05 05:20:10]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[r.kasibhatla, 2013-09-05 05:40:20]

+ jamesr for KURL.cpp

[jamesr, 2013-09-05 21:50:29]

lgtm

[commit-bot: I haz the power, 2013-09-06 01:07:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/23887002/7001

[commit-bot: I haz the power, 2013-09-06 02:40:47]

Change committed as 157343