third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp - Issue 2388693002: Make DOMWindowProperty a thin wrapper of ContextLifecycleObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp

Issue 2388693002: Make DOMWindowProperty a thin wrapper of ContextLifecycleObserver

Patch Set: temp Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp ('K') | « third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h ('k') | third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp

diff --git a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp

index 6414baef66c55afa760a044a6f1d2ab093455023..225d9fd589e9e2793c3aeeabc8026c2a14e9eb25 100644

--- a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp

+++ b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp

@@ -157,7 +157,7 @@ void ScreenOrientationControllerImpl::notifyOrientationChanged() {

void ScreenOrientationControllerImpl::setOrientation(

ScreenOrientation* orientation) {

m_orientation = orientation;

- if (m_orientation)

+ if (isActiveAndVisible())

updateOrientation();

notifyDispatcher();

}

@@ -208,9 +208,9 @@ bool ScreenOrientationControllerImpl::hasLastData() {

return true;

}

-void ScreenOrientationControllerImpl::frameDestroyed() {

+void ScreenOrientationControllerImpl::contextDestroyed() {

m_client = nullptr;

- DOMWindowProperty::frameDestroyed();

+ DOMWindowProperty::contextDestroyed();

m_activeLock = false;

}