third_party/WebKit/Source/modules/presentation/PresentationController.cpp - Issue 2388693002: Make DOMWindowProperty a thin wrapper of ContextLifecycleObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationController.cpp

Issue 2388693002: Make DOMWindowProperty a thin wrapper of ContextLifecycleObserver

Patch Set: temp Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp ('K') | « third_party/WebKit/Source/modules/presentation/PresentationController.h ('k') | third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationController.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationController.cpp b/third_party/WebKit/Source/modules/presentation/PresentationController.cpp

index 7794675c11459cbdea3ab766dd5fa6aebee6a58b..1d4b6a6c169a64acb909fb3200ca1757c0893089 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationController.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationController.cpp

@@ -140,12 +140,12 @@ void PresentationController::registerConnection(

m_connections.add(connection);

}

-void PresentationController::frameDestroyed() {

+void PresentationController::contextDestroyed() {

if (m_client) {

m_client->setController(nullptr);

m_client = nullptr;

}

- DOMWindowProperty::frameDestroyed();

+ DOMWindowProperty::contextDestroyed();

}

PresentationConnection* PresentationController::findConnection(