third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp - Issue 2388693002: Make DOMWindowProperty a thin wrapper of ContextLifecycleObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp

Issue 2388693002: Make DOMWindowProperty a thin wrapper of ContextLifecycleObserver

Patch Set: temp Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp ('K') | « third_party/WebKit/Source/modules/installedapp/InstalledAppController.h ('k') | third_party/WebKit/Source/modules/presentation/PresentationController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp

diff --git a/third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp b/third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp

index 16346d0ec7438a68c0b2424cc6e75b883e5cdbdb..4cf6724e7224f7e41ee74bd392f27a4eda9682e4 100644

--- a/third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp

+++ b/third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp

@@ -51,9 +51,9 @@ void InstalledAppController::getInstalledApps(

m_client->getInstalledRelatedApps(url, std::move(callback));

}

-void InstalledAppController::frameDestroyed() {

+void InstalledAppController::contextDestroyed() {

m_client = nullptr;

- DOMWindowProperty::frameDestroyed();

+ DOMWindowProperty::contextDestroyed();

}

DEFINE_TRACE(InstalledAppController) {