third_party/WebKit/Source/core/frame/LocalFrame.cpp - Issue 2388693002: Make DOMWindowProperty a thin wrapper of ContextLifecycleObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 2388693002: Make DOMWindowProperty a thin wrapper of ContextLifecycleObserver

Patch Set: temp Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

index eff2a0ca095333329cdc9880221ce0fc37ee5136..4f886d803ef6b7f458679541990e0c4de9cf9ce0 100644

--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

@@ -431,7 +431,7 @@ void LocalFrame::detach(FrameDetachType type) {

m_host->eventHandlerRegistry().didRemoveAllEventHandlers(*localDOMWindow());

- localDOMWindow()->frameDestroyed();

+ localDOMWindow()->contextDestroyed();

// TODO: Page should take care of updating focus/scrolling instead of Frame.

// TODO: It's unclear as to why this is called more than once, but it is,