Make DOMWindowProperty a thin wrapper of ContextLifecycleObserver

Make DOMWindowProperty a thin wrapper of ContextLifecycleObserver

This CL makes DOMWindowProperty a thin wrapper of ContextLifecycleObserver
in preparation for deprecating DOMWindowProperty.
This won't have any change in behavior.

BUG=610176

[haraken, 2016-10-03 07:07:36]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 07:07:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 07:57:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 07:57:28]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[haraken, 2016-10-04 04:26:49]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 04:26:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 05:16:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 05:16:58]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[haraken, 2016-10-04 06:42:28]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 06:42:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 07:31:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 07:31:30]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[haraken, 2016-10-04 08:14:38]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 08:14:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 09:03:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 09:03:58]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[haraken, 2016-10-05 10:57:34]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 10:57:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 11:20:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 11:20:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2016-12-07 09:42:16]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 09:42:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 10:17:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 10:17:20]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[haraken, 2016-12-12 02:01:18]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 02:01:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 02:46:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 02:46:17]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[haraken, 2016-12-12 06:02:33]

haraken@chromium.org changed reviewers:
+ dcheng@chromium.org, sigbjornf@opera.com

[haraken, 2016-12-12 06:02:34]

Not for landing.

This CL is trying to replace all DOMWindowProperties with
ContextLifecycleObservers in one go but it seems a bit too aggressive -- I
couldn't finish fixing all test failures.

Let me proceed with the replacement more incrementally.

[dcheng, 2016-12-12 06:50:51]

LGTM

https://codereview.chromium.org/2388693002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp (left):

https://codereview.chromium.org/2388693002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp:491:
m_properties.remove(property);
Oh wow... this hasn't been called in some time.

[haraken, 2016-12-12 06:53:18]

On 2016/12/12 06:50:51, dcheng wrote:
> LGTM
> 
>
https://codereview.chromium.org/2388693002/diff/140001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp (left):
> 
>
https://codereview.chromium.org/2388693002/diff/140001/third_party/WebKit/Sou...
> third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp:491:
> m_properties.remove(property);
> Oh wow... this hasn't been called in some time.

Thanks, but a couple of tests are still failing and I couldn't identify the
cause because this CL replaces all DOMWindowProperties in one go. I'll try to
replace them more incrementally.

[haraken, 2016-12-12 06:54:28]

https://codereview.chromium.org/2388693002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp (left):

https://codereview.chromium.org/2388693002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp:491:
m_properties.remove(property);
On 2016/12/12 06:50:50, dcheng wrote:
> Oh wow... this hasn't been called in some time.

It would be okay because m_properties is a hash set of weak members. We need to
call unregisterProperty only when we want to promptly remove the entry from the
hash set.

[sof, 2016-12-12 13:00:50]

https://codereview.chromium.org/2388693002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp (left):

https://codereview.chromium.org/2388693002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp:491:
m_properties.remove(property);
On 2016/12/12 06:54:28, haraken wrote:
> On 2016/12/12 06:50:50, dcheng wrote:
> > Oh wow... this hasn't been called in some time.
> 
> It would be okay because m_properties is a hash set of weak members. We need
to
> call unregisterProperty only when we want to promptly remove the entry from
the
> hash set.

Yes, I wouldn't be too surprised if there are a couple of unused unregistration
methods like that still around in the codebase.

[haraken, 2016-12-19 08:51:34]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 08:51:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 09:52:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 09:52:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)