Chromium Code Reviews| Index: scripts/slave/recipe_modules/chromium/api.py |
| diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py |
| index d709175717da6963c05988630ac71c7aa7b37e62..093159021af460ddd1cef417adea4988bef8474f 100644 |
| --- a/scripts/slave/recipe_modules/chromium/api.py |
| +++ b/scripts/slave/recipe_modules/chromium/api.py |
| @@ -187,8 +187,10 @@ class ChromiumApi(recipe_api.RecipeApi): |
| # Use explicit goma deps cache dir if it's set in the path config. |
|
ukai
2016/10/04 01:24:43
update comment?
shinyak
2016/10/04 08:19:16
Removed the comment.
|
| # Otherwise use the default one inside build output directory. |
| try: |
| - args.extend(['--goma-deps-cache-dir', self.m.path['goma_deps_cache']]) |
| - except KeyError: |
| + safe_buildername = re.sub(r'[^a-zA-Z0-9]', '_', |
| + self.m.properties['buildername']) + '.gomadeps' |
| + args.extend(['--goma-deps-cache-file', safe_buildername]) |
| + except KeyError: # pragma: nocover |
|
Paweł Hajdan Jr.
2016/10/03 10:04:54
Could you remove the try-except? We could get KeyE
shinyak
2016/10/04 08:19:16
Done.
|
| pass |
| if self.c.compile_py.build_args: |