Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 2388683002: Re-enable DepsCache using GOMA_DEPS_CACHE_FILE (Closed)
Patch Set: Presubmit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« scripts/slave/compile.py ('K') | « scripts/slave/compile.py ('k') | scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium/api.py
diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py
index d709175717da6963c05988630ac71c7aa7b37e62..093159021af460ddd1cef417adea4988bef8474f 100644
--- a/scripts/slave/recipe_modules/chromium/api.py
+++ b/scripts/slave/recipe_modules/chromium/api.py
@@ -187,8 +187,10 @@ class ChromiumApi(recipe_api.RecipeApi):
# Use explicit goma deps cache dir if it's set in the path config.
# Otherwise use the default one inside build output directory.
try:
- args.extend(['--goma-deps-cache-dir', self.m.path['goma_deps_cache']])
- except KeyError:
+ safe_buildername = re.sub(r'[^a-zA-Z0-9]', '_',
+ self.m.properties['buildername']) + '.gomadeps'
+ args.extend(['--goma-deps-cache-file', safe_buildername])
+ except KeyError: # pragma: nocover
pass
if self.c.compile_py.build_args:
« scripts/slave/compile.py ('K') | « scripts/slave/compile.py ('k') | scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698