Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2388673003: [css-flexbox] Wrap comments at 80 characters (Closed)

Created:
4 years, 2 months ago by cbiesinger
Modified:
4 years, 2 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] Wrap comments at 80 characters Also for deprecated flexbox R=eae@chromium.org Committed: https://crrev.com/a97502df26f798c413dda0ca9107fec5f3ecd86c Cr-Commit-Position: refs/heads/master@{#422575}

Patch Set 1 #

Patch Set 2 : fix up .h as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -169 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp View 20 chunks +72 lines, -43 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h View 1 4 chunks +13 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 40 chunks +165 lines, -118 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
cbiesinger
4 years, 2 months ago (2016-10-03 18:53:19 UTC) #1
eae
LGTM Please make sure to update https://docs.google.com/spreadsheets/d/1B8a7O2FP6L67qpkYRrdvEJkgVAUuHZwrKbGZdh7O4KU/edit#gid=0
4 years, 2 months ago (2016-10-03 19:38:58 UTC) #2
cbiesinger
> Please make sure to update > https://docs.google.com/spreadsheets/d/1B8a7O2FP6L67qpkYRrdvEJkgVAUuHZwrKbGZdh7O4KU/edit#gid=0 Thanks, done
4 years, 2 months ago (2016-10-03 19:51:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388673003/20001
4 years, 2 months ago (2016-10-03 19:51:39 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-03 22:44:35 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 22:48:38 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a97502df26f798c413dda0ca9107fec5f3ecd86c
Cr-Commit-Position: refs/heads/master@{#422575}

Powered by Google App Engine
This is Rietveld 408576698