LayoutTests/fast/canvas/draw-focus-if-needed-with-path2d.html - Issue 238863002: Implement drawFocusIfNeeded with Path2D parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/canvas/draw-focus-if-needed-with-path2d.html

Issue 238863002: Implement drawFocusIfNeeded with Path2D parameter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/canvas/draw-focus-if-needed-expected.txt ('k') | LayoutTests/fast/canvas/draw-focus-if-needed-with-path2d-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/canvas/draw-focus-if-needed-with-path2d.html

diff --git a/LayoutTests/fast/canvas/draw-focus-if-needed.html b/LayoutTests/fast/canvas/draw-focus-if-needed-with-path2d.html

similarity index 68%

copy from LayoutTests/fast/canvas/draw-focus-if-needed.html

copy to LayoutTests/fast/canvas/draw-focus-if-needed-with-path2d.html

index 8bfb2ea3bfefca1cead0a7fbe0dd3cb2a3933937..24731b8fdb5cc620a9a2615a06f123e2c8394da3 100644

--- a/LayoutTests/fast/canvas/draw-focus-if-needed.html

+++ b/LayoutTests/fast/canvas/draw-focus-if-needed-with-path2d.html

@@ -1,6 +1,6 @@

<!DOCTYPE HTML>

<head>

-<title>Canvas test: drawFocusIfNeeded</title>

+<title>Canvas test: drawFocusIfNeeded with Path2D</title>

</head>

@@ -16,22 +16,26 @@ document.getElementById("button1").focus();

var canvas = document.getElementById("canvas").getContext("2d");

+shouldThrow('canvas.drawFocusIfNeeded(undefined);');

+shouldThrow('canvas.drawFocusIfNeeded(undefined, undefined);');

shouldThrow('canvas.drawFocusIfNeeded(null);');

+shouldThrow('canvas.drawFocusIfNeeded(null, null);');

shouldThrow('canvas.drawFocusIfNeeded();');

-canvas.beginPath();

-canvas.rect(50, 50, 200, 100);

+var path = new Path2D();

+path.rect(50, 50, 200, 100);

canvas.fillStyle = "#ccf";

-canvas.fill();

+canvas.fill(path);

// re-test null case after having defined a path (regression test for crbug.com/353248)

shouldThrow('canvas.drawFocusIfNeeded(null);');

-canvas.drawFocusIfNeeded(document.getElementById("button1"));

+shouldThrow('canvas.drawFocusIfNeeded(null, null);');

+canvas.drawFocusIfNeeded(path, document.getElementById("button1"));

-canvas.beginPath();

-canvas.rect(50, 200, 200, 100);

+path = new Path2D();

+path.rect(50, 200, 200, 100);

canvas.fillStyle = "#cfc";

-canvas.fill();

-canvas.drawFocusIfNeeded(document.getElementById("button2"));

+canvas.fill(path);

+canvas.drawFocusIfNeeded(path, document.getElementById("button2"));

// The top rect"s focus ring is tied to button1, which is focused.

// It should have an outline in some color other than the background color.