Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 238863002: Implement drawFocusIfNeeded with Path2D parameter. (Closed)

Created:
6 years, 8 months ago by zino
Modified:
6 years, 8 months ago
Reviewers:
Rik, Justin Novosad
CC:
blink-reviews, arv+blink, dglazkov+blink, adamk+blink_chromium.org, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Implement drawFocusIfNeeded with Path2D parameter. Add version of drawFocusIfNeeded that take a Path2D parameter. Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/MGxEfzBPw68 BUG=330506 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171757

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -15 lines) Patch
M LayoutTests/fast/canvas/draw-focus-if-needed-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + LayoutTests/fast/canvas/draw-focus-if-needed-with-path2d.html View 2 chunks +13 lines, -9 lines 0 comments Download
A LayoutTests/fast/canvas/draw-focus-if-needed-with-path2d-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 2 chunks +14 lines, -4 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
zino
Please take a look. Thank you!
6 years, 8 months ago (2014-04-15 08:45:13 UTC) #1
Justin Novosad
On 2014/04/15 08:45:13, zino wrote: > Please take a look. > > Thank you! Fantastic! ...
6 years, 8 months ago (2014-04-15 14:25:22 UTC) #2
Rik
On 2014/04/15 08:45:13, zino wrote: > Please take a look. > > Thank you! not ...
6 years, 8 months ago (2014-04-15 20:26:16 UTC) #3
Rik
On 2014/04/15 20:26:16, Rik wrote: > On 2014/04/15 08:45:13, zino wrote: > > Please take ...
6 years, 8 months ago (2014-04-15 20:29:20 UTC) #4
Justin Novosad
On 2014/04/15 20:26:16, Rik wrote: > > This new API needs to have an optional ...
6 years, 8 months ago (2014-04-15 21:05:14 UTC) #5
Rik
On 2014/04/15 21:05:14, junov wrote: > On 2014/04/15 20:26:16, Rik wrote: > > > > ...
6 years, 8 months ago (2014-04-15 21:36:58 UTC) #6
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 8 months ago (2014-04-16 04:24:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/238863002/40001
6 years, 8 months ago (2014-04-16 04:25:21 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-16 04:54:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-16 04:54:25 UTC) #10
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 8 months ago (2014-04-16 06:51:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/238863002/60001
6 years, 8 months ago (2014-04-16 06:52:03 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 08:36:24 UTC) #13
Message was sent while issue was closed.
Change committed as 171757

Powered by Google App Engine
This is Rietveld 408576698