Source/core/html/HTMLDialogElement.h - Issue 23886003: Have HTMLElements / SVGElements constructors take a Document reference in argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLDialogElement.h

Issue 23886003: Have HTMLElements / SVGElements constructors take a Document reference in argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Another Android build fix Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLDialogElement.h

diff --git a/Source/core/html/HTMLDialogElement.h b/Source/core/html/HTMLDialogElement.h

index b871159aa1db7e8c3caa7453bbf15de6514a35b0..5e301a87fe06d8e05ddb78b285b0bfd76f472fed 100644

--- a/Source/core/html/HTMLDialogElement.h

+++ b/Source/core/html/HTMLDialogElement.h

@@ -36,7 +36,7 @@ class QualifiedName;

class HTMLDialogElement FINAL : public HTMLElement {

public:

- static PassRefPtr<HTMLDialogElement> create(const QualifiedName&, Document*);

+ static PassRefPtr<HTMLDialogElement> create(const QualifiedName&, Document&);

void close(const String& returnValue, ExceptionState&);

void show();

@@ -46,7 +46,7 @@ public:

void setReturnValue(const String& returnValue) { m_returnValue = returnValue; }

private:

- HTMLDialogElement(const QualifiedName&, Document*);

+ HTMLDialogElement(const QualifiedName&, Document&);

virtual PassRefPtr<RenderStyle> customStyleForRenderer() OVERRIDE;

virtual bool isPresentationAttribute(const QualifiedName&) const OVERRIDE;

« no previous file with comments | « Source/core/html/HTMLDetailsElement.cpp ('k') | Source/core/html/HTMLDialogElement.cpp » ('j') | no next file with comments »