Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 23886002: remove Isolate::Current from most files starting with 'f' through 'i' (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

remove Isolate::Current from most files starting with 'f' through 'i' R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16506

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -79 lines) Patch
M src/frames.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/heap.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M src/heap-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap-snapshot-generator.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/heap-snapshot-generator.cc View 1 2 7 chunks +12 lines, -10 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic.h View 8 chunks +19 lines, -19 lines 0 comments Download
M src/ic.cc View 5 chunks +23 lines, -21 lines 0 comments Download
M src/isolate.h View 1 2 2 chunks +3 lines, -9 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate-inl.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-visiting-inl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
dcarney
7 years, 3 months ago (2013-09-03 09:15:23 UTC) #1
Sven Panne
https://codereview.chromium.org/23886002/diff/4001/src/heap-snapshot-generator.h File src/heap-snapshot-generator.h (right): https://codereview.chromium.org/23886002/diff/4001/src/heap-snapshot-generator.h#newcode418 src/heap-snapshot-generator.h:418: V8HeapExplorer(Heap* heap, I don't think we need this: A ...
7 years, 3 months ago (2013-09-03 10:42:08 UTC) #2
dcarney
https://chromiumcodereview.appspot.com/23886002/diff/4001/src/heap-snapshot-generator.h File src/heap-snapshot-generator.h (right): https://chromiumcodereview.appspot.com/23886002/diff/4001/src/heap-snapshot-generator.h#newcode418 src/heap-snapshot-generator.h:418: V8HeapExplorer(Heap* heap, On 2013/09/03 10:42:08, Sven Panne wrote: > ...
7 years, 3 months ago (2013-09-03 11:12:21 UTC) #3
Sven Panne
lgtm
7 years, 3 months ago (2013-09-03 11:40:28 UTC) #4
dcarney
7 years, 3 months ago (2013-09-03 11:48:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r16506 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698