bluetooth: Add AdapterInfo in Bluetooth adapter service.

chrome/browser/resources/bluetooth_internals/bluetooth_internals.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Javascript for bluetooth_internals.html, served from
  *     chrome://bluetooth-internals/.
  */
 
 /**
@@ skipping 18 matching lines @@
   deviceRemoved: function(device) {
     console.log('Device removed');
     console.log(device);
   }
 };
 
 (function() {
   var adapter, adapterClient;
 
   /**
-   * TODO: Move to shared location. See crbug.com/652361.
+   * Logs basic information retrieved from the adapter.
+   */
+  function logAdapterInfo() {
+    console.log('Getting adapter info');

[dcheng, 2016/10/06 18:46:28]

I'm not sure what our policy on logging code is in JS, but it seems like this
should be removed before landing.

[mbrunson, 2016/10/06 21:00:22]

Eventually, this JS file will turn into a setup file for a Polymer-based user
interface. I'm trying to establish a minimal Mojo service before I implement
that. I don't know what's the recommended way/process for a work-in-progress
WebUI so I've just been using logs to make sure things are being created and
sent correctly to the WebUI.

+
+    return adapter.getInfo().then(function(response) {
+      console.log(response.info);
+    });
+  }
+
+  /**
+   * TODO: Move to shared location. See http://crbug.com/652361.
    * Helper to convert callback-based define() API to a promise-based API.
    * @param {!Array<string>} moduleNames
    * @return {!Promise}
    */
   function importModules(moduleNames) {
     return new Promise(function(resolve, reject) {
       define(moduleNames, function(var_args) {
         resolve(Array.prototype.slice.call(arguments, 0));
       });
     });
@@ skipping 32 matching lines @@
           // Create a message pipe and bind one end to client
           // implementation and the other to the Adapter service.
           adapterClient = new AdapterClient();
           adapter.setClient(connection.bindStubDerivedImpl(adapterClient));
       });
     });
   }
 
   document.addEventListener('DOMContentLoaded', function() {
     initializeProxies()
+      .then(logAdapterInfo)

[dpapad, 2016/10/06 22:25:21]

Let's be consistent within this file. Either

initializeProxies()
  .then(logAdapterInfo)
  .then(logDevices)
  .catch(function(error) { console.error(error); });

Or you can compress as follows

initializeProxies()
  .then(function() {return adapter.getInfo(); })
  .then(function(response) { console.log('info', response.info); })
  .then(function() { return adapter.getDevices(); })
  .then(function(response) { console.log('devices', response.devices); })
  .catch(function(error) { console.error(error); });

I think latter is better, since this UI is at very early development phase, no
good reason to make named temporary functions like logAdapterInfo(), anonymous
functions seem enough.

Also regarding testing this Mojo-based UI, maybe better to start thinking about
it soon, before it becomes a full fledged UI. An example of mocking a
Mojo-generated class (like Adapter) can be found at
https://cs.chromium.org/chromium/src/chrome/test/data/webui/plugins_browserte....

[mbrunson, 2016/10/07 00:48:11]

Alright. Thanks for the link. Latter looks better to me also. Done.

       .then(function() { return adapter.getDevices(); })
       .then(function(response) { console.log(response.devices); })
       .catch(function(error) { console.error(error); });
   });
 })();