bluetooth: Add AdapterInfo in Bluetooth adapter service.

bluetooth: Add AdapterInfo in Bluetooth adapter service.

Adds getter for basic information about the state of the
system's Bluetooth adapter including:
  + Address
  + Name
  + Initialization state
  + Presence
  + Power state
  + Discovering state
  + Discoverable state

This information is logged in the browser console once it's
retrieved in JS.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/68edb718679b840bcac21d56febc5b76e338fe65
Cr-Commit-Position: refs/heads/master@{#423936}

[mbrunson, 2016-09-30 22:09:16]

Description was changed from

==========
bluetooth: Add basic getters in Bluetooth adapter service.

Adds getters for basic information about the state of the system's Bluetooth
adapter including:
  + Name
  + Power State
  + Presence

This information is logged in the browser console once it's retrieved in JS.

BUG=651282
==========

to

==========
bluetooth: Add basic getters in Bluetooth adapter service.

Adds getters for basic information about the state of the system's Bluetooth
adapter including:
  + Name
  + Power State
  + Presence

This information is logged in the browser console once it's retrieved in JS.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[mbrunson, 2016-09-30 22:30:20]

Description was changed from

==========
bluetooth: Add basic getters in Bluetooth adapter service.

Adds getters for basic information about the state of the system's Bluetooth
adapter including:
  + Name
  + Power State
  + Presence

This information is logged in the browser console once it's retrieved in JS.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
bluetooth: Add basic getters in Bluetooth adapter service.

Adds getters for basic information about the state of the system's Bluetooth
adapter including:
  + Address
  + Name
  + Power State
  + Presence

This information is logged in the browser console once it's retrieved in JS.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[mbrunson, 2016-09-30 23:41:36]

mbrunson@chromium.org changed reviewers:
+ scheib@chromium.org

[scheib, 2016-10-01 00:26:50]

LGTM pending ortuno's decision on pattern style in
https://codereview.chromium.org/2379573006/

https://codereview.chromium.org/2388533003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
(right):

https://codereview.chromium.org/2388533003/diff/40001/chrome/browser/resource...
chrome/browser/resources/bluetooth_internals/bluetooth_internals.js:46:
adapter.getAddress().then(function(response) {
Perhaps we should have an AdapterInfo struct and fold Address, Name, Powered,
Present all into that with just one accessor?

https://codereview.chromium.org/2388533003/diff/40001/device/bluetooth/adapte...
File device/bluetooth/adapter.cc (right):

https://codereview.chromium.org/2388533003/diff/40001/device/bluetooth/adapte...
device/bluetooth/adapter.cc:37: callback.Run(adapter->GetAddress());
Optional:
callback.Run(adapter ? adapter->GetAddress() : "");

[mbrunson, 2016-10-03 17:40:09]

mbrunson@chromium.org changed reviewers:
+ ortuno@chromium.org

[mbrunson, 2016-10-03 17:40:10]

https://codereview.chromium.org/2388533003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
(right):

https://codereview.chromium.org/2388533003/diff/40001/chrome/browser/resource...
chrome/browser/resources/bluetooth_internals/bluetooth_internals.js:46:
adapter.getAddress().then(function(response) {
On 2016/10/01 00:26:49, scheib wrote:
> Perhaps we should have an AdapterInfo struct and fold Address, Name, Powered,
> Present all into that with just one accessor? 

I agree.

[scheib, 2016-10-03 18:50:33]

On 2016/10/03 17:40:10, mbrunson wrote:
>
https://codereview.chromium.org/2388533003/diff/40001/chrome/browser/resource...
> File chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
> (right):
> 
>
https://codereview.chromium.org/2388533003/diff/40001/chrome/browser/resource...
> chrome/browser/resources/bluetooth_internals/bluetooth_internals.js:46:
> adapter.getAddress().then(function(response) {
> On 2016/10/01 00:26:49, scheib wrote:
> > Perhaps we should have an AdapterInfo struct and fold Address, Name,
Powered,
> > Present all into that with just one accessor? 
> 
> I agree.

Still LGTM pending ortuno's decision on pattern style in
https://codereview.chromium.org/2379573006/

[mbrunson, 2016-10-03 19:53:17]

Description was changed from

==========
bluetooth: Add basic getters in Bluetooth adapter service.

Adds getters for basic information about the state of the system's Bluetooth
adapter including:
  + Address
  + Name
  + Power State
  + Presence

This information is logged in the browser console once it's retrieved in JS.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
bluetooth: Add AdapterInfo in Bluetooth adapter service.

Adds getter for basic information about the state of the
system's Bluetooth adapter including:
  + Address
  + Name
  + Initialization state
  + Presence
  + Power state
  + Discovering state
  + Discoverable state

This information is logged in the browser console once it's
retrieved in JS.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[ortuno, 2016-10-06 01:52:21]

lgtm bar a nit and a question.

https://codereview.chromium.org/2388533003/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
(right):

https://codereview.chromium.org/2388533003/diff/140001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/bluetooth_internals.js:47:
adapter.getInfo().then(function(response) { console.log(response.info); });
Q: Did you mean to return the promise here? Or is this something you want to do
in parallel?

https://codereview.chromium.org/2388533003/diff/140001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/bluetooth_internals.js:102:
.then(function() { logAdapterInfo(); })
nit: Can you just do:

.then(logAdapterInfo)

?

[ortuno, 2016-10-06 01:52:22]

lgtm bar a nit and a question.

[mbrunson, 2016-10-06 17:45:02]

https://codereview.chromium.org/2388533003/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
(right):

https://codereview.chromium.org/2388533003/diff/140001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/bluetooth_internals.js:47:
adapter.getInfo().then(function(response) { console.log(response.info); });
On 2016/10/06 01:52:21, ortuno wrote:
> Q: Did you mean to return the promise here? Or is this something you want to
do
> in parallel?

I didn't return it because I didn't care what order the information was logged
in. For consistency, I'll put a return here.

https://codereview.chromium.org/2388533003/diff/140001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/bluetooth_internals.js:102:
.then(function() { logAdapterInfo(); })
On 2016/10/06 01:52:21, ortuno wrote:
> nit: Can you just do:
> 
> .then(logAdapterInfo)
> 
> ?

Done.

[mbrunson, 2016-10-06 17:48:07]

The CQ bit was checked by mbrunson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 17:48:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mbrunson, 2016-10-06 18:23:44]

mbrunson@chromium.org changed reviewers:
+ dcheng@chromium.org, dpapad@chromium.org

[mbrunson, 2016-10-06 18:23:45]

OWNERS review, please:

dcheng:
  device/bluetooth/public/interfaces/adapter.mojom

dpapad:
  chrome/browser/resources/bluetooth_internals/bluetooth_internals.js

[dcheng, 2016-10-06 18:46:28]

mojo lgtm with a nit

https://codereview.chromium.org/2388533003/diff/180001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
(right):

https://codereview.chromium.org/2388533003/diff/180001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/bluetooth_internals.js:42:
console.log('Getting adapter info');
I'm not sure what our policy on logging code is in JS, but it seems like this
should be removed before landing.

[mbrunson, 2016-10-06 21:00:22]

https://codereview.chromium.org/2388533003/diff/180001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
(right):

https://codereview.chromium.org/2388533003/diff/180001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/bluetooth_internals.js:42:
console.log('Getting adapter info');
On 2016/10/06 18:46:28, dcheng wrote:
> I'm not sure what our policy on logging code is in JS, but it seems like this
> should be removed before landing.

Eventually, this JS file will turn into a setup file for a Polymer-based user
interface. I'm trying to establish a minimal Mojo service before I implement
that. I don't know what's the recommended way/process for a work-in-progress
WebUI so I've just been using logs to make sure things are being created and
sent correctly to the WebUI.

[dpapad, 2016-10-06 22:25:21]

https://codereview.chromium.org/2388533003/diff/180001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
(right):

https://codereview.chromium.org/2388533003/diff/180001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/bluetooth_internals.js:103:
.then(logAdapterInfo)
Let's be consistent within this file. Either

initializeProxies()
  .then(logAdapterInfo)
  .then(logDevices)
  .catch(function(error) { console.error(error); });

Or you can compress as follows

initializeProxies()
  .then(function() {return adapter.getInfo(); })
  .then(function(response) { console.log('info', response.info); })
  .then(function() { return adapter.getDevices(); })
  .then(function(response) { console.log('devices', response.devices); })
  .catch(function(error) { console.error(error); });

I think latter is better, since this UI is at very early development phase, no
good reason to make named temporary functions like logAdapterInfo(), anonymous
functions seem enough.

Also regarding testing this Mojo-based UI, maybe better to start thinking about
it soon, before it becomes a full fledged UI. An example of mocking a
Mojo-generated class (like Adapter) can be found at
https://cs.chromium.org/chromium/src/chrome/test/data/webui/plugins_browserte....

[mbrunson, 2016-10-07 00:48:11]

https://codereview.chromium.org/2388533003/diff/180001/chrome/browser/resourc...
File chrome/browser/resources/bluetooth_internals/bluetooth_internals.js
(right):

https://codereview.chromium.org/2388533003/diff/180001/chrome/browser/resourc...
chrome/browser/resources/bluetooth_internals/bluetooth_internals.js:103:
.then(logAdapterInfo)
On 2016/10/06 22:25:21, dpapad wrote:
> Let's be consistent within this file. Either
> 
> initializeProxies()
>   .then(logAdapterInfo)
>   .then(logDevices)
>   .catch(function(error) { console.error(error); });
> 
> Or you can compress as follows
> 
> initializeProxies()
>   .then(function() {return adapter.getInfo(); })
>   .then(function(response) { console.log('info', response.info); })
>   .then(function() { return adapter.getDevices(); })
>   .then(function(response) { console.log('devices', response.devices); })
>   .catch(function(error) { console.error(error); });
> 
> I think latter is better, since this UI is at very early development phase, no
> good reason to make named temporary functions like logAdapterInfo(), anonymous
> functions seem enough.
> 
> Also regarding testing this Mojo-based UI, maybe better to start thinking
about
> it soon, before it becomes a full fledged UI. An example of mocking a
> Mojo-generated class (like Adapter) can be found at
>
https://cs.chromium.org/chromium/src/chrome/test/data/webui/plugins_browserte....

Alright. Thanks for the link. Latter looks better to me also. Done.

[dpapad, 2016-10-07 02:10:06]

lgtm

[mbrunson, 2016-10-07 17:50:00]

The CQ bit was checked by mbrunson@chromium.org

[mbrunson, 2016-10-07 17:50:00]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
ortuno@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2388533003/#ps200001
(title: "JS changes, remove const")

[commit-bot: I haz the power, 2016-10-07 17:50:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 19:42:35]

Description was changed from

==========
bluetooth: Add AdapterInfo in Bluetooth adapter service.

Adds getter for basic information about the state of the
system's Bluetooth adapter including:
  + Address
  + Name
  + Initialization state
  + Presence
  + Power state
  + Discovering state
  + Discoverable state

This information is logged in the browser console once it's
retrieved in JS.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
bluetooth: Add AdapterInfo in Bluetooth adapter service.

Adds getter for basic information about the state of the
system's Bluetooth adapter including:
  + Address
  + Name
  + Initialization state
  + Presence
  + Power state
  + Discovering state
  + Discoverable state

This information is logged in the browser console once it's
retrieved in JS.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-07 19:42:36]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-10-07 19:44:22]

Description was changed from

==========
bluetooth: Add AdapterInfo in Bluetooth adapter service.

Adds getter for basic information about the state of the
system's Bluetooth adapter including:
  + Address
  + Name
  + Initialization state
  + Presence
  + Power state
  + Discovering state
  + Discoverable state

This information is logged in the browser console once it's
retrieved in JS.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
bluetooth: Add AdapterInfo in Bluetooth adapter service.

Adds getter for basic information about the state of the
system's Bluetooth adapter including:
  + Address
  + Name
  + Initialization state
  + Presence
  + Power state
  + Discovering state
  + Discoverable state

This information is logged in the browser console once it's
retrieved in JS.

BUG=651282
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/68edb718679b840bcac21d56febc5b76e338fe65
Cr-Commit-Position: refs/heads/master@{#423936}
==========

[commit-bot: I haz the power, 2016-10-07 19:44:23]

Patchset 11 (id:??) landed as
https://crrev.com/68edb718679b840bcac21d56febc5b76e338fe65
Cr-Commit-Position: refs/heads/master@{#423936}