Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2388503002: Mac: Use SecPolicyCreateSSL instead of CreatePolicy(&CSSMOID_APPLE_TP_SSL, ...) (Closed)

Created:
4 years, 2 months ago by mattm
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Mac: Use SecPolicyCreateSSL instead of CreatePolicy(&CSSMOID_APPLE_TP_SSL, ...) Fixes client cert selector not showing client certs that were not directly issued by the specified root(s) on Sierra. Also use SecPolicyCreateBasicX509 instead of CreatePolicy(&CSSMOID_APPLE_X509_BASIC, ...). (Should have no effect, but may be safer / more future-proof.) BUG=649953 Review-Url: https://codereview.chromium.org/2373533003 Cr-Commit-Position: refs/heads/master@{#421598} (cherry picked from commit 9d33bc396faca1d6d017ed22894197e51c16d6e5) Committed: https://chromium.googlesource.com/chromium/src/+/7f6568a8aca70454edfa9c2c72c3ab2eed2b83d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M net/cert/x509_util_mac.cc View 2 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mattm
4 years, 2 months ago (2016-09-30 21:06:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7f6568a8aca70454edfa9c2c72c3ab2eed2b83d8.

Powered by Google App Engine
This is Rietveld 408576698