Source/bindings/v8/V8LazyEventListener.cpp - Issue 23885006: Pass isolate to V8LazyEventListener constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8LazyEventListener.cpp

Issue 23885006: Pass isolate to V8LazyEventListener constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/V8LazyEventListener.cpp

diff --git a/Source/bindings/v8/V8LazyEventListener.cpp b/Source/bindings/v8/V8LazyEventListener.cpp

index f899de4bc46a2cbb7d2b6388b6f0ef087b8b9297..9553b1c6aea99d8465a33363de2e5ed3624309c3 100644

--- a/Source/bindings/v8/V8LazyEventListener.cpp

+++ b/Source/bindings/v8/V8LazyEventListener.cpp

@@ -52,8 +52,8 @@

namespace WebCore {

-V8LazyEventListener::V8LazyEventListener(const AtomicString& functionName, const AtomicString& eventParameterName, const String& code, const String sourceURL, const TextPosition& position, Node* node)

- : V8AbstractEventListener(true, mainThreadNormalWorld(), v8::Isolate::GetCurrent()) // FIXME Remove GetCurrent()

+V8LazyEventListener::V8LazyEventListener(const AtomicString& functionName, const AtomicString& eventParameterName, const String& code, const String sourceURL, const TextPosition& position, Node* node, v8::Isolate* isolate)

+ : V8AbstractEventListener(true, mainThreadNormalWorld(), isolate)

, m_functionName(functionName)

, m_eventParameterName(eventParameterName)

, m_code(code)

« no previous file with comments | « Source/bindings/v8/V8LazyEventListener.h ('k') | no next file » | no next file with comments »