Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 2388483004: Make merge driver complain about older gits (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke, dcheng
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make merge driver complain about older gits The git coming with Xcode 7.0 is too old to know about %P. Most people will be on newer Xcodes (and Trusty's git and depot_tools's Windows git are new enough), so this doesn't affect most folks -- so just complaining loudly is good enough. BUG=574611 TBR=dpranke Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9bd40a63c45e834e335121123275ec968d73f1c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M clang_format_merge_driver.py View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
dcheng
Tested locally, LGTM (not an owner though)
4 years, 2 months ago (2016-10-01 01:35:06 UTC) #4
Nico
dpranke: I'll owner-tbr this (blocks reopening the tree)
4 years, 2 months ago (2016-10-01 01:36:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388483004/1
4 years, 2 months ago (2016-10-01 01:36:21 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/9bd40a63c45e834e335121123275ec968d73f1c7
4 years, 2 months ago (2016-10-01 01:39:18 UTC) #15
Dirk Pranke
4 years, 2 months ago (2016-10-01 02:27:25 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698