Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 2388463002: [inspector] fix use-after-free in ConsoleHelper::reportCall (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
Reviewers:
alph, dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] fix use-after-free in ConsoleHelper::reportCall InspectedContext can be destroyed inside of V8ConsoleMessage::createForConsoleAPI call. BUG=chromium:646175 R=dgozman@chromium.org,alph@chromium.org Committed: https://crrev.com/d99308ef55806590355d9f6d14428a532788af95 Cr-Commit-Position: refs/heads/master@{#39939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/inspector/v8-console.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
kozy
Dmitry, please take a look!
4 years, 2 months ago (2016-09-30 18:18:43 UTC) #1
dgozman
lgtm
4 years, 2 months ago (2016-09-30 18:54:03 UTC) #4
alph
lgtm
4 years, 2 months ago (2016-10-03 20:17:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388463002/1
4 years, 2 months ago (2016-10-03 20:42:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 21:15:51 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 21:16:11 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d99308ef55806590355d9f6d14428a532788af95
Cr-Commit-Position: refs/heads/master@{#39939}

Powered by Google App Engine
This is Rietveld 408576698