Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2388443003: MD Settings: disable border-radius when cards are expanded (Closed)

Created:
4 years, 2 months ago by Dan Beam
Modified:
4 years, 2 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: disable border-radius when cards are expanded Looks bad and is causing rendering issues. R=michaelpg@chromium.org BUG=651344 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/be74ba8f28e8d1371c2c5bdcc756ade34c47262e Cr-Commit-Position: refs/heads/master@{#422226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/resources/settings/settings_page/settings_section.html View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Dan Beam
4 years, 2 months ago (2016-09-30 19:49:12 UTC) #3
michaelpg
lgtm
4 years, 2 months ago (2016-09-30 20:39:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388443003/1
4 years, 2 months ago (2016-09-30 20:50:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 21:28:25 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 21:30:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be74ba8f28e8d1371c2c5bdcc756ade34c47262e
Cr-Commit-Position: refs/heads/master@{#422226}

Powered by Google App Engine
This is Rietveld 408576698