Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2388443002: Fix media_log() crash in fuzzer tests. (Closed)

Created:
4 years, 2 months ago by DaleCurtis
Modified:
4 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix media_log() crash in fuzzer tests. When called from this context, no MediaLog exists, so ensure we don't try to use it. BUG=610848, 650735, 651739 TEST=libfuzzer Committed: https://crrev.com/c27e432072ef22112251bbe874c8a1060a0c7ca5 Cr-Commit-Position: refs/heads/master@{#422182}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M media/formats/mpeg/adts_stream_parser.cc View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
DaleCurtis
4 years, 2 months ago (2016-09-30 17:56:42 UTC) #3
sandersd (OOO until July 31)
lgtm Would it not be better to pass in a null log sink?
4 years, 2 months ago (2016-09-30 18:00:13 UTC) #4
DaleCurtis
Would, but not all callers have a MediaLog and for those that do... code is ...
4 years, 2 months ago (2016-09-30 18:04:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388443002/1
4 years, 2 months ago (2016-09-30 18:05:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 19:34:58 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 19:37:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c27e432072ef22112251bbe874c8a1060a0c7ca5
Cr-Commit-Position: refs/heads/master@{#422182}

Powered by Google App Engine
This is Rietveld 408576698