third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp - Issue 2388423003: reflow comments in modules/[fetch,indexeddb]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp

Issue 2388423003: reflow comments in modules/[fetch,indexeddb] (Closed)

Patch Set: rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/filesystem/DirectoryReader.cpp ('k') | third_party/WebKit/Source/modules/filesystem/FileWriter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp

diff --git a/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp b/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp

index 0aaf68cee05ac84b32f74723b81fbc5a0585b5cd..23b529acbed83201b71b311e0c15426a2814d2d9 100644

--- a/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp

+++ b/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp

@@ -387,10 +387,12 @@ void SnapshotFileCallback::didCreateSnapshotFile(

if (!m_successCallback)

return;

- // We can't directly use the snapshot blob data handle because the content type on it hasn't been set.

- // The |snapshot| param is here to provide a a chain of custody thru thread bridging that is held onto until

- // *after* we've coined a File with a new handle that has the correct type set on it. This allows the

- // blob storage system to track when a temp file can and can't be safely deleted.

+ // We can't directly use the snapshot blob data handle because the content

+ // type on it hasn't been set. The |snapshot| param is here to provide a a

+ // chain of custody thru thread bridging that is held onto until *after* we've

+ // coined a File with a new handle that has the correct type set on it. This

+ // allows the blob storage system to track when a temp file can and can't be

+ // safely deleted.

handleEventOrScheduleCallback(

m_successCallback.release(),