third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.cpp - Issue 2388423003: reflow comments in modules/[fetch,indexeddb]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.cpp

Issue 2388423003: reflow comments in modules/[fetch,indexeddb] (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/filesystem/DOMWindowFileSystem.h ('K') | « third_party/WebKit/Source/modules/filesystem/DOMWindowFileSystem.h ('k') | third_party/WebKit/Source/modules/filesystem/DirectoryReader.cpp » ('j') | third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.cpp

diff --git a/third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.cpp b/third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.cpp

index f2cf8bae2eac5164d6ea2179f17c8db2dc998584..12aba0f44b438d38eac75d77891869d73982f1ff 100644

--- a/third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.cpp

+++ b/third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.cpp

@@ -68,10 +68,12 @@ Entry* DataTransferItemFileSystem::webkitGetAsEntry(

return 0;

}

- // The dropped entries are mapped as top-level entries in the isolated filesystem.

+ // The dropped entries are mapped as top-level entries in the isolated

+ // filesystem.

String virtualPath = DOMFilePath::append("/", toFile(file)->name());

- // FIXME: This involves synchronous file operation. Consider passing file type data when we dispatch drag event.

+ // FIXME: This involves synchronous file operation. Consider passing file type

+ // data when we dispatch drag event.

FileMetadata metadata;

if (!getFileMetadata(toFile(file)->path(), metadata))

return 0;