MD History: Announce search results for screen-reader users

MD History: Announce search results for screen-reader users

This adds a screen reader announcement of "Found X search results for
'Y'" when the user performs a search.

BUG=425625, 606527
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0e90425c8b66c3d9577ea82171b7d5bcd122c5a2
Cr-Commit-Position: refs/heads/master@{#423062}

[tsergeant, 2016-10-04 04:08:14]

Description was changed from

==========
MD History: Announce search results for screen-reader users

Still a WIP, do not commit.

BUG=425625
==========

to

==========
MD History: Announce search results for screen-reader users

Still a WIP, do not commit.

BUG=425625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-10-04 23:42:06]

Description was changed from

==========
MD History: Announce search results for screen-reader users

Still a WIP, do not commit.

BUG=425625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Announce search results for screen-reader users

This adds a screen reader announcement of "Found X search results for
'Y'" when the user performs a search.

BUG=425625,606527
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-10-04 23:53:21]

Patchset #2 (id:20001) has been deleted

[tsergeant, 2016-10-04 23:53:35]

Patchset #3 (id:60001) has been deleted

[tsergeant, 2016-10-04 23:54:23]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 23:54:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-10-05 00:56:57]

tsergeant@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-10-05 01:34:49]

lgtm

do we plan on removing iron-a11y-announcer-thinger after this, out of curiosity?

https://codereview.chromium.org/2388413002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_item.js (right):

https://codereview.chromium.org/2388413002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/history_item.js:328: * @param {number}
numberOfItems
nit: numberOfResults

https://codereview.chromium.org/2388413002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/history_item.js:329: * @param {string}
search
nit: searchTerm

https://codereview.chromium.org/2388413002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_history/list_container.js (right):

https://codereview.chromium.org/2388413002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/list_container.js:44: if (info.term != '' &&
!this.queryState.incremental) {
nit: if (info.term && !this.queryState.incremental) {

[tsergeant, 2016-10-05 01:57:32]

https://codereview.chromium.org/2388413002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_item.js (right):

https://codereview.chromium.org/2388413002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/history_item.js:328: * @param {number}
numberOfItems
On 2016/10/05 01:34:48, Dan Beam wrote:
> nit: numberOfResults

Done.

https://codereview.chromium.org/2388413002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/history_item.js:329: * @param {string}
search
On 2016/10/05 01:34:48, Dan Beam wrote:
> nit: searchTerm

Done.

https://codereview.chromium.org/2388413002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_history/list_container.js (right):

https://codereview.chromium.org/2388413002/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_history/list_container.js:44: if (info.term != '' &&
!this.queryState.incremental) {
On 2016/10/05 01:34:48, Dan Beam wrote:
> nit: if (info.term && !this.queryState.incremental) {

Done.

[tsergeant, 2016-10-05 01:57:40]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-10-05 01:57:41]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2388413002/#ps100001
(title: "Address nits")

[commit-bot: I haz the power, 2016-10-05 01:58:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 03:15:02]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2016-10-05 03:17:42]

Description was changed from

==========
MD History: Announce search results for screen-reader users

This adds a screen reader announcement of "Found X search results for
'Y'" when the user performs a search.

BUG=425625,606527
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Announce search results for screen-reader users

This adds a screen reader announcement of "Found X search results for
'Y'" when the user performs a search.

BUG=425625,606527
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0e90425c8b66c3d9577ea82171b7d5bcd122c5a2
Cr-Commit-Position: refs/heads/master@{#423062}
==========

[commit-bot: I haz the power, 2016-10-05 03:17:43]

Patchset 4 (id:??) landed as
https://crrev.com/0e90425c8b66c3d9577ea82171b7d5bcd122c5a2
Cr-Commit-Position: refs/heads/master@{#423062}