Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 2388403002: HostDiscardableSharedMemoryManager should store the default memory limit (Closed)

Created:
4 years, 2 months ago by bashi
Modified:
4 years, 2 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HostDiscardableSharedMemoryManager should store the default memory limit OnMemoryStateChange() callback is invoked on the UI thread but we can't call GetDefaultMemoryLimit() from the UI thread. Store the default limit on construction. BUG=652557 Committed: https://crrev.com/738aeed44f1e6f1bdbc3bf2e34eeab91e9726888 Cr-Commit-Position: refs/heads/master@{#422700}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/common/host_discardable_shared_memory_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/host_discardable_shared_memory_manager.cc View 2 chunks +3 lines, -2 lines 1 comment Download

Messages

Total messages: 13 (7 generated)
bashi
PTAL https://codereview.chromium.org/2388403002/diff/1/content/common/host_discardable_shared_memory_manager.cc File content/common/host_discardable_shared_memory_manager.cc (right): https://codereview.chromium.org/2388403002/diff/1/content/common/host_discardable_shared_memory_manager.cc#newcode167 content/common/host_discardable_shared_memory_manager.cc:167: : default_memory_limit_(GetDefaultMemoryLimit()), Though GetDefaultMemoryLimit() could be dynamically changed, ...
4 years, 2 months ago (2016-10-04 03:13:10 UTC) #4
Avi (use Gerrit)
lgtm
4 years, 2 months ago (2016-10-04 04:05:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388403002/1
4 years, 2 months ago (2016-10-04 04:06:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 04:11:35 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/738aeed44f1e6f1bdbc3bf2e34eeab91e9726888 Cr-Commit-Position: refs/heads/master@{#422700}
4 years, 2 months ago (2016-10-04 04:13:49 UTC) #12
hajimehoshi
4 years, 2 months ago (2016-10-04 04:18:23 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698