Add unittests of HTTPS loading that requires AIA fetching.

Add unittests of HTTPS loading that requires AIA fetching.

BUG=651965
NOPRESUBMIT=true

Committed: https://crrev.com/0b12a6f86f1e390267e9234dac22337600634319
Cr-Commit-Position: refs/heads/master@{#435064}

[mattm, 2016-10-20 19:55:59]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 19:56:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2016-10-20 19:57:30]

Description was changed from

==========
WIP aia test

BUG=
==========

to

==========
Add unittests of HTTPS loading that requires AIA fetching.

BUG=651965
==========

[commit-bot: I haz the power, 2016-10-20 20:18:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 20:18:06]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mattm, 2016-10-20 20:57:44]

mattm@chromium.org changed reviewers:
+ davidben@chromium.org

[davidben, 2016-10-21 22:42:27]

lgtm

https://codereview.chromium.org/2388393002/diff/60001/net/tools/testserver/mi...
File net/tools/testserver/minica.py (right):

https://codereview.chromium.org/2388393002/diff/60001/net/tools/testserver/mi...
net/tools/testserver/minica.py:484: ca_issuers_url = "http://127.0.0.1",
Doesn't seem these defaults are ever used.

https://codereview.chromium.org/2388393002/diff/60001/net/url_request/url_req...
File net/url_request/url_request_unittest.cc (right):

https://codereview.chromium.org/2388393002/diff/60001/net/url_request/url_req...
net/url_request/url_request_unittest.cc:9629: // some OSX versions that is not
the case.
Just to confirm, you mean that on OSX versions they do have an effect, but you
are testing that we smooth over that effect?

[mattm, 2016-10-21 23:22:36]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 23:23:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattm, 2016-10-21 23:24:20]

https://codereview.chromium.org/2388393002/diff/60001/net/tools/testserver/mi...
File net/tools/testserver/minica.py (right):

https://codereview.chromium.org/2388393002/diff/60001/net/tools/testserver/mi...
net/tools/testserver/minica.py:484: ca_issuers_url = "http://127.0.0.1",
On 2016/10/21 22:42:27, davidben wrote:
> Doesn't seem these defaults are ever used.

removed.

https://codereview.chromium.org/2388393002/diff/60001/net/url_request/url_req...
File net/url_request/url_request_unittest.cc (right):

https://codereview.chromium.org/2388393002/diff/60001/net/url_request/url_req...
net/url_request/url_request_unittest.cc:9629: // some OSX versions that is not
the case.
On 2016/10/21 22:42:27, davidben wrote:
> Just to confirm, you mean that on OSX versions they do have an effect, but you
> are testing that we smooth over that effect?

Well.. on sierra I discovered the previous workaround wasn't doing it properly
in all cases. I hope to fix that in a separate CL. There aren't sierra bots, so
I don't know if it matters too much but I could wait to land this until that is
fixed if you want.

[commit-bot: I haz the power, 2016-10-22 00:18:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-22 00:18:36]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[davidben, 2016-10-22 01:28:18]

https://codereview.chromium.org/2388393002/diff/60001/net/url_request/url_req...
File net/url_request/url_request_unittest.cc (right):

https://codereview.chromium.org/2388393002/diff/60001/net/url_request/url_req...
net/url_request/url_request_unittest.cc:9629: // some OSX versions that is not
the case.
On 2016/10/21 23:24:20, mattm wrote:
> On 2016/10/21 22:42:27, davidben wrote:
> > Just to confirm, you mean that on OSX versions they do have an effect, but
you
> > are testing that we smooth over that effect?
> 
> Well.. on sierra I discovered the previous workaround wasn't doing it properly
> in all cases. I hope to fix that in a separate CL. There aren't sierra bots,
so
> I don't know if it matters too much but I could wait to land this until that
is
> fixed if you want.

Ah, I see. I dunno if we try to avoid checking in failing tests like that. My
gut feeling would be that you should probably fix it first since developers
might be on Sierra (???), but your call.

[mattm, 2016-11-15 23:04:29]

On 2016/10/22 01:28:18, davidben (at IETF until 11-19) wrote:
>
https://codereview.chromium.org/2388393002/diff/60001/net/url_request/url_req...
> File net/url_request/url_request_unittest.cc (right):
> 
>
https://codereview.chromium.org/2388393002/diff/60001/net/url_request/url_req...
> net/url_request/url_request_unittest.cc:9629: // some OSX versions that is not
> the case.
> On 2016/10/21 23:24:20, mattm wrote:
> > On 2016/10/21 22:42:27, davidben wrote:
> > > Just to confirm, you mean that on OSX versions they do have an effect, but
> you
> > > are testing that we smooth over that effect?
> > 
> > Well.. on sierra I discovered the previous workaround wasn't doing it
properly
> > in all cases. I hope to fix that in a separate CL. There aren't sierra bots,
> so
> > I don't know if it matters too much but I could wait to land this until that
> is
> > fixed if you want.
> 
> Ah, I see. I dunno if we try to avoid checking in failing tests like that. My
> gut feeling would be that you should probably fix it first since developers
> might be on Sierra (???), but your call.

fwiw, I ended up removing the parameterized test part. Making it work on sierra
was hard due to the issue with "require positive results" commented here:  
https://cs.chromium.org/chromium/src/net/cert/x509_util_mac.cc?type=cs&q=CSSM...
(I guess I could update the testserver to put do both caissuers and ocsp at the
same time.. I'd just like to get the basic test in though.)

[mattm, 2016-11-15 23:05:36]

The CQ bit was checked by mattm@chromium.org

[mattm, 2016-11-15 23:05:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/2388393002/#ps120001
(title: "remove parameterized test")

[commit-bot: I haz the power, 2016-11-15 23:06:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 23:28:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 23:28:09]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mattm, 2016-11-15 23:34:13]

Description was changed from

==========
Add unittests of HTTPS loading that requires AIA fetching.

BUG=651965
==========

to

==========
Add unittests of HTTPS loading that requires AIA fetching.

BUG=651965
NOPRESUBMIT=true
==========

[mattm, 2016-11-15 23:38:22]

On 2016/11/15 23:28:09, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

setting NOPRESUBMIT due to the long lines in minica.py (large integer literals
that can't be wrapped.)

[mattm, 2016-11-15 23:38:49]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2016-11-15 23:39:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 00:31:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 00:31:36]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mattm, 2016-11-16 00:55:03]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2016-11-16 00:55:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 01:41:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 01:41:16]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mattm, 2016-11-16 01:42:25]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2016-11-16 01:43:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 02:13:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 02:13:20]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mattm, 2016-11-16 02:16:02]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2016-11-16 02:16:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 04:18:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 04:18:22]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mattm, 2016-11-16 22:16:32]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2016-11-16 22:17:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 00:41:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 00:41:30]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, no build
URL)

[mattm, 2016-11-17 01:11:41]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2016-11-17 01:13:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 02:55:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 02:55:21]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mattm, 2016-11-17 02:56:21]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2016-11-17 02:57:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 03:17:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 03:17:20]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)

[mattm, 2016-11-17 20:17:26]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 20:19:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 02:19:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 02:19:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mattm, 2016-11-29 02:06:30]

Patchset #10 (id:180001) has been deleted

[mattm, 2016-11-29 02:09:18]

The CQ bit was checked by mattm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 02:10:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 04:02:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 04:02:29]

Dry run: This issue passed the CQ dry run.

[mattm, 2016-11-29 19:53:01]

The CQ bit was checked by mattm@chromium.org

[mattm, 2016-11-29 19:53:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/2388393002/#ps200001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-29 19:53:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 19:57:20]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1480449181848730,
"parent_rev": "1edf3256f1156b7c2ac9590683365a9dd1edfa07", "commit_rev":
"5602a071397ab44ef5e24abecffc9e6849bcef34"}

[commit-bot: I haz the power, 2016-11-29 19:57:46]

Description was changed from

==========
Add unittests of HTTPS loading that requires AIA fetching.

BUG=651965
NOPRESUBMIT=true
==========

to

==========
Add unittests of HTTPS loading that requires AIA fetching.

BUG=651965
NOPRESUBMIT=true
==========

[commit-bot: I haz the power, 2016-11-29 19:57:49]

Committed patchset #10 (id:200001)

[commit-bot: I haz the power, 2016-11-29 20:01:56]

Description was changed from

==========
Add unittests of HTTPS loading that requires AIA fetching.

BUG=651965
NOPRESUBMIT=true
==========

to

==========
Add unittests of HTTPS loading that requires AIA fetching.

BUG=651965
NOPRESUBMIT=true

Committed: https://crrev.com/0b12a6f86f1e390267e9234dac22337600634319
Cr-Commit-Position: refs/heads/master@{#435064}
==========

[commit-bot: I haz the power, 2016-11-29 20:01:57]

Patchset 10 (id:??) landed as
https://crrev.com/0b12a6f86f1e390267e9234dac22337600634319
Cr-Commit-Position: refs/heads/master@{#435064}