Simplify SafeBrowsingBlockingPageBrowserTest.IframeOptInAndReportThreatDetails

Simplify SafeBrowsingBlockingPageBrowserTest.IframeOptInAndReportThreatDetails
test cases to reduce flakiness.
Also corrected some constant names (malware->malicious), since tests are not
limited to malware threat type.

BUG=652567
Committed: https://crrev.com/f789d6d04bc5de7c37a7799a0cb843c5e687b385
Cr-Commit-Position: refs/heads/master@{#423981}

[Jialiu Lin, 2016-10-04 22:59:27]

The CQ bit was checked by jialiul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 22:59:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jialiu Lin, 2016-10-04 23:01:05]

Description was changed from

==========
Simplify SafeBrowsingBlockingPageBrowserTest.IframeOptInAndReportThreatDetails
test cases to reduce flakiness.

BUG=652567
==========

to

==========
Simplify SafeBrowsingBlockingPageBrowserTest.IframeOptInAndReportThreatDetails
test cases to reduce flakiness.
Also corrected some constant names (malware->malicious), since tests are not
limited to malware threat type.

BUG=652567
==========

[Jialiu Lin, 2016-10-04 23:04:36]

The CQ bit was unchecked by jialiul@chromium.org

[Jialiu Lin, 2016-10-05 00:12:50]

jialiul@chromium.org changed reviewers:
+ nparker@chromium.org

[Jialiu Lin, 2016-10-05 00:12:51]

Hi nparker@, 
Here is my attempt to fix the flakiness of
SafeBrowsingBlockingPageBrowserTest.IframeOptInAndReportThreatDetails
(crbug.com/652567).
I am unable to reproduce this issue locally on Win10.
This flakiness might indirectly due to crbug.com/76460. 
In the original test case, there is an iframe pointing to a non-existing URL
(http://example.com/cross_site_iframe.html), and it will eventually cause
navigating
to an error page (and got canceled?). So if this iframe comes back first and
triggers interstitial, it is very likely clicking on proceed cause problem
described in crbug.com/76460.

This is only my educated guess. I removed all the none-exiting resources in this
test case and only keep the necessary, hope it can resolve the flakiness.

[Jialiu Lin, 2016-10-07 02:08:11]

nparker@,
Could you take a look?

[Nathan Parker, 2016-10-07 21:07:27]

lgtm

[Jialiu Lin, 2016-10-07 21:14:02]

The CQ bit was checked by jialiul@chromium.org

[commit-bot: I haz the power, 2016-10-07 21:14:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 22:16:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-07 22:18:08]

Description was changed from

==========
Simplify SafeBrowsingBlockingPageBrowserTest.IframeOptInAndReportThreatDetails
test cases to reduce flakiness.
Also corrected some constant names (malware->malicious), since tests are not
limited to malware threat type.

BUG=652567
==========

to

==========
Simplify SafeBrowsingBlockingPageBrowserTest.IframeOptInAndReportThreatDetails
test cases to reduce flakiness.
Also corrected some constant names (malware->malicious), since tests are not
limited to malware threat type.

BUG=652567

Committed: https://crrev.com/f789d6d04bc5de7c37a7799a0cb843c5e687b385
Cr-Commit-Position: refs/heads/master@{#423981}
==========

[commit-bot: I haz the power, 2016-10-07 22:18:09]

Patchset 2 (id:??) landed as
https://crrev.com/f789d6d04bc5de7c37a7799a0cb843c5e687b385
Cr-Commit-Position: refs/heads/master@{#423981}