Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2388323002: Remove some obsolete GYP references in chrome/ (Closed)

Created:
4 years, 2 months ago by Lei Zhang
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some obsolete GYP references in chrome/ Committed: https://crrev.com/e512d0ade4defa8e154ae5f82e683d9aac31c3d7 Cr-Commit-Position: refs/heads/master@{#422953}

Patch Set 1 #

Total comments: 2

Patch Set 2 : no isolates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M chrome/OWNERS View 1 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/android/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/features.gni View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/installer/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Lei Zhang
4 years, 2 months ago (2016-10-03 23:17:19 UTC) #2
Dirk Pranke
lgtm https://codereview.chromium.org/2388323002/diff/1/chrome/OWNERS File chrome/OWNERS (left): https://codereview.chromium.org/2388323002/diff/1/chrome/OWNERS#oldcode17 chrome/OWNERS:17: per-file *.isolate=vadimsh@chromium.org Can you remove the *.isolate file ...
4 years, 2 months ago (2016-10-04 20:27:45 UTC) #7
Lei Zhang
https://codereview.chromium.org/2388323002/diff/1/chrome/OWNERS File chrome/OWNERS (left): https://codereview.chromium.org/2388323002/diff/1/chrome/OWNERS#oldcode17 chrome/OWNERS:17: per-file *.isolate=vadimsh@chromium.org On 2016/10/04 20:27:45, Dirk Pranke (slow) wrote: ...
4 years, 2 months ago (2016-10-04 20:37:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388323002/20001
4 years, 2 months ago (2016-10-04 20:37:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 22:09:05 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e512d0ade4defa8e154ae5f82e683d9aac31c3d7 Cr-Commit-Position: refs/heads/master@{#422953}
4 years, 2 months ago (2016-10-04 22:11:35 UTC) #14
Lei Zhang
On 2016/10/04 20:27:45, Dirk Pranke (slow) wrote: > Can you remove the *.isolate file references ...
4 years, 2 months ago (2016-10-07 01:40:13 UTC) #15
Dirk Pranke
4 years, 2 months ago (2016-10-07 16:23:25 UTC) #16
Message was sent while issue was closed.
On 2016/10/07 01:40:13, Lei Zhang wrote:
> On 2016/10/04 20:27:45, Dirk Pranke (slow) wrote:
> > Can you remove the *.isolate file references as well?
> 
> BTW, chrome/*.isolate still exists. Should they be deleted?

Probably. It's possible skia or v8 might still need isolates for something, but
I'd try to delete things and see what happened.

Powered by Google App Engine
This is Rietveld 408576698