Flash: Use better APIs for preventing sleep

chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/pepper/pepper_flash_browser_host.h"
 
 #include "base/time/time.h"
 #include "build/build_config.h"
 #include "chrome/browser/content_settings/cookie_settings_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "components/content_settings/core/browser/cookie_settings.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_ppapi_host.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_process_host.h"
+#include "device/power_save_blocker/power_save_blocker.h"
 #include "ipc/ipc_message_macros.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/c/private/ppb_flash.h"
 #include "ppapi/host/dispatch_host_message.h"
 #include "ppapi/proxy/ppapi_messages.h"
 #include "ppapi/proxy/resource_message_params.h"
 #include "ppapi/shared_impl/time_conversion.h"
 #include "url/gurl.h"
 
 #if defined(OS_WIN)
@@ skipping 47 matching lines @@
     PPAPI_DISPATCH_HOST_RESOURCE_CALL(PpapiHostMsg_Flash_GetLocalTimeZoneOffset,
                                       OnGetLocalTimeZoneOffset)
     PPAPI_DISPATCH_HOST_RESOURCE_CALL_0(
         PpapiHostMsg_Flash_GetLocalDataRestrictions, OnGetLocalDataRestrictions)
   PPAPI_END_MESSAGE_MAP()
   return PP_ERROR_FAILED;
 }
 
 int32_t PepperFlashBrowserHost::OnUpdateActivity(
     ppapi::host::HostMessageContext* host_context) {
-#if defined(OS_WIN)
-  // Reading then writing back the same value to the screensaver timeout system
-  // setting resets the countdown which prevents the screensaver from turning
-  // on "for a while". As long as the plugin pings us with this message faster
-  // than the screensaver timeout, it won't go on.
-  int value = 0;
-  if (SystemParametersInfo(SPI_GETSCREENSAVETIMEOUT, 0, &value, 0))
-    SystemParametersInfo(SPI_SETSCREENSAVETIMEOUT, value, NULL, 0);
-#elif defined(OS_MACOSX)
-  UpdateSystemActivity(OverallAct);
-#else
-// TODO(brettw) implement this for other platforms.
-#endif
+  device::PowerSaveBlocker* blocker = new device::PowerSaveBlocker(
+      device::PowerSaveBlocker::kPowerSaveBlockPreventAppSuspension,
+      device::PowerSaveBlocker::kReasonOther, "Requested By PepperFlash",
+      BrowserThread::GetTaskRunnerForThread(BrowserThread::UI),
+      BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE));
+  auto delete_blocker = [](device::PowerSaveBlocker* blocker) {
+    delete blocker;
+  };
+  // There is no specification for how long OnUpdateActivity should prevent the
+  // screen from going to sleep. Empirically, twitch.tv calls this method every
+  // 10 seconds. Be conservative and allow 45 seconds before deleting the block.
+  BrowserThread::PostDelayedTask(BrowserThread::IO, FROM_HERE,
+                                 base::Bind(delete_blocker, blocker),
+                                 base::TimeDelta::FromSeconds(45));

[bbudge, 2016/10/13 19:53:51]

Since this is a plugin API, it seems bad to allow the plugin to create an
unlimited number of PowerSaveBlocker instances.

Could you instead hold a reference to the PowerSaveBlocker on this host class,
and post tasks to reset that reference? You'd have to check in UpdateActivity
for a pending task and kill that before launching another.

[ccameron, 2016/10/14 21:39:43]

Sure -- switched it to a DelayTimer impl.

   return PP_OK;
 }
 
 int32_t PepperFlashBrowserHost::OnGetLocalTimeZoneOffset(
     ppapi::host::HostMessageContext* host_context,
     const base::Time& t) {
   // The reason for this processing being in the browser process is that on
   // Linux, the localtime calls require filesystem access prohibited by the
   // sandbox.
   host_context->reply_msg = PpapiPluginMsg_Flash_GetLocalTimeZoneOffsetReply(
@@ skipping 51 matching lines @@
       restrictions = PP_FLASHLSORESTRICTIONS_BLOCK;
     else if (cookie_settings_->IsCookieSessionOnly(plugin_url))
       restrictions = PP_FLASHLSORESTRICTIONS_IN_MEMORY;
   }
   SendReply(reply_context,
             PpapiPluginMsg_Flash_GetLocalDataRestrictionsReply(
                 static_cast<int32_t>(restrictions)));
 }
 
 }  // namespace chrome