[turbofan] Introduces a step to verify the machine graph.

[turbofan] Introduces a step to verify the machine graph.

It is currently being rolled behind the --turbo_verify_machine_graph flag.

BUG=

Committed: https://crrev.com/83a93560938c7fe6f8418b4746be6805bd9e2cfe
Cr-Commit-Position: refs/heads/master@{#39976}

[epertoso, 2016-10-04 10:28:18]

Patchset #1 (id:1) has been deleted

[epertoso, 2016-10-04 13:07:17]

Description was changed from

==========
[turbofan] Introduces a step to verify the machine graph.

BUG=
==========

to

==========
[turbofan] Introduces a step to verify the machine graph.

It is currently being rolled behind the --turbo_verify_machine_graph flag.

BUG=
==========

[epertoso, 2016-10-04 13:07:17]

epertoso@chromium.org changed reviewers:
+ bmeurer@chromium.org, jarin@chromium.org

[epertoso, 2016-10-04 13:07:27]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 13:07:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 13:13:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 13:13:22]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/15485)

[epertoso, 2016-10-04 14:02:38]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 14:02:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 14:13:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 14:13:16]

Dry run: Try jobs failed on following builders:
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/15493)

[Benedikt Meurer, 2016-10-05 03:40:19]

bmeurer@chromium.org changed reviewers:
+ ishell@chromium.org

[Benedikt Meurer, 2016-10-05 03:40:19]

bmeurer@chromium.org changed required reviewers:
+ ishell@chromium.org

[Benedikt Meurer, 2016-10-05 03:40:20]

LGTM to me. Adding Igor.

[Igor Sheludko, 2016-10-05 07:34:45]

lgtm

[epertoso, 2016-10-05 07:57:28]

The CQ bit was checked by epertoso@chromium.org

[commit-bot: I haz the power, 2016-10-05 07:57:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2016-10-05 08:16:17]

lgtm with some nits (no need to address immediately).

https://codereview.chromium.org/2388313003/diff/80001/src/compiler/machine-gr...
File src/compiler/machine-graph-verifier.cc (right):

https://codereview.chromium.org/2388313003/diff/80001/src/compiler/machine-gr...
src/compiler/machine-graph-verifier.cc:28:
representation_vector_(graph->NodeCount(), zone) {
Explicit initialization with MachineRepresentation::kNone

https://codereview.chromium.org/2388313003/diff/80001/src/compiler/machine-gr...
src/compiler/machine-graph-verifier.cc:224: break;
As discussed offline, it could be nicer to have a complete list of cases here
and no default case. This would mean listing all the opcodes (using the 2nd
order macros from opcodes.h), so it might get too ugly.

The advantage is that after adding a new machine operator, the compiler would
remind you to update the validator.

Same for the switch below.

[commit-bot: I haz the power, 2016-10-05 08:27:57]

Description was changed from

==========
[turbofan] Introduces a step to verify the machine graph.

It is currently being rolled behind the --turbo_verify_machine_graph flag.

BUG=
==========

to

==========
[turbofan] Introduces a step to verify the machine graph.

It is currently being rolled behind the --turbo_verify_machine_graph flag.

BUG=
==========

[commit-bot: I haz the power, 2016-10-05 08:27:58]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-10-05 08:28:21]

Description was changed from

==========
[turbofan] Introduces a step to verify the machine graph.

It is currently being rolled behind the --turbo_verify_machine_graph flag.

BUG=
==========

to

==========
[turbofan] Introduces a step to verify the machine graph.

It is currently being rolled behind the --turbo_verify_machine_graph flag.

BUG=

Committed: https://crrev.com/83a93560938c7fe6f8418b4746be6805bd9e2cfe
Cr-Commit-Position: refs/heads/master@{#39976}
==========

[commit-bot: I haz the power, 2016-10-05 08:28:22]

Patchset 4 (id:??) landed as
https://crrev.com/83a93560938c7fe6f8418b4746be6805bd9e2cfe
Cr-Commit-Position: refs/heads/master@{#39976}